Skip to content

[vs]: Add vs test support for bitmap VNET#792

Merged
prsunny merged 3 commits intosonic-net:masterfrom
volodymyrsamotiy:vnet_bitmap
Apr 12, 2019
Merged

[vs]: Add vs test support for bitmap VNET#792
prsunny merged 3 commits intosonic-net:masterfrom
volodymyrsamotiy:vnet_bitmap

Conversation

@volodymyrsamotiy
Copy link
Copy Markdown
Collaborator

@volodymyrsamotiy volodymyrsamotiy commented Feb 15, 2019

Signed-off-by: Volodymyr Samotiy [email protected]

What I did
Added vs test support for bitmap VNET implementation.

Why I did it
It is done in order to have vs tests running for the bitmap VNET implementation.

How I verified it
Executed all vs tests (including this new test) and verified that all passed.

Details if related
Depends on the following PRs:

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Feb 15, 2019

There are some failures for the Vnet bitmap test, can you check?

@volodymyrsamotiy
Copy link
Copy Markdown
Collaborator Author

volodymyrsamotiy commented Feb 15, 2019

There are failures because implementation of "bitmap VNET" is not merged yet and also it depends on some other PRs.
In PR description there is a list of PRs that should be merged first:

Depends on the following PRs:

@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Mar 7, 2019

retest this please

2 similar comments
@liat-grozovik
Copy link
Copy Markdown
Collaborator

retest this please

@liat-grozovik
Copy link
Copy Markdown
Collaborator

retest this please

@volodymyrsamotiy volodymyrsamotiy force-pushed the vnet_bitmap branch 2 times, most recently from 3eb2baa to 4ea372e Compare March 26, 2019 11:52
@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Apr 8, 2019

retest this please

1 similar comment
@prsunny
Copy link
Copy Markdown
Collaborator

prsunny commented Apr 11, 2019

retest this please

@sonic-net sonic-net deleted a comment from volodymyrsamotiy Apr 11, 2019
Volodymyr Samotiy added 3 commits April 12, 2019 07:19
* Move definition of bitmap VNET helper class to test_vnet.py

Signed-off-by: Volodymyr Samotiy <[email protected]>
@prsunny prsunny merged commit 0179917 into sonic-net:master Apr 12, 2019
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
* [neighbor advertiser] remove http endpoint access

Signed-off-by: Ying Xie <[email protected]>

* Remove obsolete comment
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
* [vs]: Add vs test support for bitmap VNET

* Move definition of bitmap VNET helper class to test_vnet.py

* [vs]: Add "local route" vs test support for bitmap VNET

Signed-off-by: Volodymyr Samotiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants