Move QoS configuration to config DB#378
Merged
yxieca merged 3 commits intosonic-net:masterfrom Nov 21, 2017
Merged
Conversation
Signed-off-by: Andriy Moroz <[email protected]>
This was referenced Nov 10, 2017
Collaborator
|
Build triggered. sha1 is merged. |
1 similar comment
Collaborator
|
Build triggered. sha1 is merged. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
Build finished. No test results found. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
Build finished. No test results found. |
Signed-off-by: Andriy Moroz <[email protected]>
andriymoroz-mlnx
force-pushed
the
qos_config
branch
from
d248a81 to
bf60822
Compare
yxieca
reviewed
Nov 20, 2017
| ref_resolve_status resolve_result; | ||
| // sample "QUEUE_TABLE:ETHERNET4:1" | ||
| tokens = tokenize(key, delimiter); | ||
| tokens = tokenize(key, delimiter2); |
Contributor
There was a problem hiding this comment.
The example doesn't match the code change here. Can you also update the example?
yxieca
reviewed
Nov 20, 2017
| using namespace swss; | ||
|
|
||
| const char delimiter = ':'; | ||
| const char delimiter2 = '|'; |
Contributor
There was a problem hiding this comment.
delimiter2 doesn't tell what it is separating, can you give it a more meaningful name? like field_delimiter if it is separating fields, or attr_delimiter if it is separating attributes, for example.
yxieca
approved these changes
Nov 20, 2017
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
I have a couple non-blocking issue on this review. Otherwise it looks good to me.
Signed-off-by: Andriy Moroz <[email protected]>
yxieca
approved these changes
Nov 21, 2017
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
root@node1# config warm_restart bgp_timer 14 root@node1# show warm_restart config name enable timer_name timer_duration ------ -------- ------------ ---------------- bgp false bgp_timer 14 system true NULL NULL root@7d3e5fba80c0:/# config warm_restart enable bgp root@7d3e5fba80c0:/# show warm_restart config name enable timer_name timer_duration ------ -------- ------------ ---------------- bgp true bgp_timer 14 system false NULL NULL Signed-off-by: Rodny Molina <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…c-net#378) Signed-off-by: Ying Xie <[email protected]>
jianyuewu
pushed a commit
to jianyuewu/sonic-swss
that referenced
this pull request
Dec 24, 2025
* Address Review comments sonic-net/sonic-swss-common#376 to remove DB specific API from selectable class which is generic. However to access to the Derviced Class Redis Select API via python we need to downcast the the Selectable Object. Added Helpfer function to do same. Ref: http://www.swig.org/Doc3.0/Python.html Signed-off-by: Abhishek Dosi <[email protected]> * Align the code properly Signed-off-by: Abhishek Dosi <[email protected]> * Address Review Comments. Return the DBConnector Pointer. Since the DBConnector is unique_ptr return the reference to the contained object, or a non owning pointer Signed-off-by: Abhishek Dosi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Move QoS configuration to config DB
See also:
sonic-net/sonic-swss-common#158
sonic-net/sonic-buildimage#1162