[hash]: Implement GH backend by nazariig · Pull Request #2598 · sonic-net/sonic-swss

nazariig · 2023-01-04T12:39:10Z

Signed-off-by: Nazarii Hnydyn [email protected]

DEPENDS:

HLD: sonic-net/SONiC#1101

What I did

Implemented Generic Hash feature

Why I did it

Implementation is done according to the Generic Hash HLD

How I verified it

Run Generic Hash VS UTs

Details if related

N/A

nazariig · 2023-02-14T16:31:07Z

@prsunny could you please have a look?

nazariig · 2023-02-23T15:03:14Z

@prsunny just a kind reminder

nazariig · 2023-02-28T19:51:04Z

@prsunny just a kind reminder

nazariig · 2023-03-09T18:21:09Z

@prsunny just a kind reminder

nazariig · 2023-03-16T16:30:57Z

@prsunny just a kind reminder

nazariig · 2023-05-09T08:03:36Z

/azpw run

mssonicbld · 2023-05-09T08:03:38Z

/AzurePipelines run

azure-pipelines · 2023-05-09T08:03:49Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-05-10T12:53:37Z

/azpw run

mssonicbld · 2023-05-10T12:53:39Z

/AzurePipelines run

azure-pipelines · 2023-05-10T12:53:49Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-05-12T17:36:14Z

@prsunny so what's the plan here? Are we going to continue the review?

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig · 2023-06-02T21:14:27Z

@prsunny review comments have been addressed. Please have a look.

nazariig · 2023-06-07T08:54:20Z

@prsunny just a kind reminder

nazariig · 2023-06-13T14:39:23Z

@prsunny just a kind reminder

* [hash]: Implement GH backend as per HLD: sonic-net/SONiC#1101

StormLiangMS · 2023-09-21T06:28:07Z

new feature, no backport

baxia-lan · 2023-12-05T21:30:58Z

+
+    sai_attribute_t attr;
+
+    attr.id = SAI_HASH_ATTR_NATIVE_HASH_FIELD_LIST;


Do you have plan to support SAI_SWITCH_ATTR_ECMP_HASH_IPV4/SAI_SWITCH_ATTR_ECMP_HASH_IPV4_IN_IPV4/SAI_SWITCH_ATTR_ECMP_HASH_IPV6 /SAI_SWITCH_ATTR_LAG_HASH_IPV4/SAI_SWITCH_ATTR_LAG_HASH_IPV4_IN_IPV4/SAI_SWITCH_ATTR_LAG_HASH_IPV6 besides the default hash field list?

@baxia-lan no. Implementation is according to the HLD. Also, this topic was discussed during Community design review and folks agreed that it requires some HLD/SAI extension in order to support hashing for different types of encapsulated frames per ASIC vendor. In any case, currently no plans to work on it.

Thanks for the heads up. Could you please provide the pointer of the HLD discussion recording for these concerns? Also if possible, could you please help me to clarify the SAI extension needed?

@baxia-lan regarding the recording, please speak to @zhangyanzhao

…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

…onic-net#13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

…onic-net#13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

…13316) What is the motivation for this PR? These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore. These are from the change sonic-net/sonic-swss#2598. r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute." r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*" r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*" How did you do it?

nazariig requested a review from prsunny as a code owner January 4, 2023 12:39

nazariig force-pushed the master-hash-rel branch from b43a3be to 083f416 Compare January 4, 2023 12:44

nazariig mentioned this pull request Jan 4, 2023

Generic Hash HLD sonic-net/SONiC#1101

Merged

nazariig requested review from liat-grozovik and volodymyrsamotiy January 5, 2023 17:04

nazariig force-pushed the master-hash-rel branch 2 times, most recently from 818d875 to 8bf8a73 Compare January 16, 2023 16:19

nazariig force-pushed the master-hash-rel branch 2 times, most recently from 6a66934 to 15c71b0 Compare February 14, 2023 10:30

nazariig requested a review from abdosi April 7, 2023 23:22

nazariig force-pushed the master-hash-rel branch from 15c71b0 to 021cc2c Compare April 26, 2023 09:17

nazariig force-pushed the master-hash-rel branch from 021cc2c to 96dc2bc Compare May 6, 2023 12:31

nazariig force-pushed the master-hash-rel branch from 96dc2bc to a9ce172 Compare May 9, 2023 20:27

prsunny requested changes May 13, 2023

View reviewed changes

nazariig force-pushed the master-hash-rel branch from a9ce172 to 9d8b3d0 Compare June 1, 2023 13:48

[hash]: Implement GH backend.

58f8df3

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig force-pushed the master-hash-rel branch 2 times, most recently from 6849bce to fd7aeb5 Compare June 1, 2023 19:27

nazariig force-pushed the master-hash-rel branch from fd7aeb5 to b21328e Compare June 1, 2023 20:04

[hash]: Handle review comments.

2cc8534

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig force-pushed the master-hash-rel branch from b21328e to 2cc8534 Compare June 1, 2023 20:17

prsunny reviewed Jun 15, 2023

View reviewed changes

Comment thread orchagent/switch/switch_capabilities.cpp

prsunny approved these changes Jun 26, 2023

View reviewed changes

prsunny merged commit a67f684 into sonic-net:master Jun 26, 2023

nazariig added the Request for 202305 Branch label Jul 10, 2023

theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 20, 2023

[hash]: Implement GH backend (sonic-net#2598)

75dd6b5

* [hash]: Implement GH backend as per HLD: sonic-net/SONiC#1101

dgsudharsan removed the Request for 202305 Branch label Oct 9, 2023

baxia-lan reviewed Dec 5, 2023

View reviewed changes

byu343 mentioned this pull request Jun 15, 2024

Add loganalyzer_common_ignore regexs for config reload on broadcom sonic-net/sonic-mgmt#13316

Merged

8 tasks

mssonicbld mentioned this pull request Jun 25, 2024

[action] [PR:13316] Add loganalyzer_common_ignore regexs for config reload on broadcom sonic-net/sonic-mgmt#13442

Merged

8 tasks

mssonicbld mentioned this pull request Jul 4, 2024

[action] [PR:13316] Add loganalyzer_common_ignore regexs for config reload on broadcom sonic-net/sonic-mgmt#13558

Merged

8 tasks


		sai_attribute_t attr;

		attr.id = SAI_HASH_ATTR_NATIVE_HASH_FIELD_LIST;

Conversation

nazariig commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nazariig commented Feb 14, 2023

Uh oh!

nazariig commented Feb 23, 2023

Uh oh!

nazariig commented Feb 28, 2023

Uh oh!

nazariig commented Mar 9, 2023

Uh oh!

nazariig commented Mar 16, 2023

Uh oh!

nazariig commented May 9, 2023

Uh oh!

mssonicbld commented May 9, 2023

Uh oh!

azure-pipelines bot commented May 9, 2023

Uh oh!

nazariig commented May 10, 2023

Uh oh!

mssonicbld commented May 10, 2023

Uh oh!

azure-pipelines bot commented May 10, 2023

Uh oh!

nazariig commented May 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nazariig commented Jun 2, 2023

Uh oh!

nazariig commented Jun 7, 2023

Uh oh!

nazariig commented Jun 13, 2023

Uh oh!

Uh oh!

StormLiangMS commented Sep 21, 2023

Uh oh!

baxia-lan Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

nazariig Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

baxia-lan Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

nazariig Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nazariig commented Jan 4, 2023 •

edited

Loading