[ledd] prevent ledd crash on recirc port event#232
Merged
sujinmkang merged 1 commit intosonic-net:masterfrom Dec 17, 2021
Merged
[ledd] prevent ledd crash on recirc port event#232sujinmkang merged 1 commit intosonic-net:masterfrom
sujinmkang merged 1 commit intosonic-net:masterfrom
Conversation
judyjoseph
approved these changes
Dec 10, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-platform-daemons |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sujinmkang
approved these changes
Dec 17, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Jan 23, 2022
Description Prevent ledd crash when an event on recirc port happens Motivation and Context A recirculation port is not a physical interface tied to a xcvr Calling the led change event on such a port could lead to a ledd crash How Has This Been Tested? This change was applied to running switch with its dependency sonic-net/sonic-buildimage#9471 Verified that ledd runs without crashing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent ledd crash when an event on recirc port happens
Motivation and Context
A recirculation port is not a physical interface tied to a xcvr
Calling the led change event on such a port could lead to a ledd crash
How Has This Been Tested?
This change was applied to running switch with its dependency sonic-net/sonic-buildimage#9471
Verified that ledd runs without crashing
Additional Information (Optional)
Cherry-pick required for 202106