Fix a bug at removing asics on not-online cards#203
Merged
judyjoseph merged 1 commit intosonic-net:masterfrom Sep 14, 2021
Merged
Fix a bug at removing asics on not-online cards#203judyjoseph merged 1 commit intosonic-net:masterfrom
judyjoseph merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Ngoc Do <[email protected]>
Contributor
Author
|
Add @mprabhu-nokia for review. |
mprabhu-nokia
approved these changes
Jul 29, 2021
Contributor
mprabhu-nokia
left a comment
mprabhu-nokia
left a comment
There was a problem hiding this comment.
Did you get to check if some underlying implementation changed because of which the table.get() returns a list instead of tuple?
Contributor
|
@judyjoseph Could you please review? |
Contributor
Author
I didn't have chance to look at if it's because of table implementation change since I fixed on our code base that recently got upgraded. |
judyjoseph
approved these changes
Aug 31, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 14, 2021
Fix a bug coming from PR #175 when asic is removed due to card getting offline (before it was online).
vdahiya12
added a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…from YCableBase required for Y-Cable API's in sonic-platform-daemons (sonic-net#203) This PR adds support for YCable class required for platform-daemons to use the YCable API's for credo. Description Basically a vendor specific implementation of abstract YCableBase class . detailed design discussion can be found https://github.com/Azure/SONiC/pull/757/files Motivation and Context Required for transitioning to vendor agnostic API's to be called by xcvrd, so that all types of cables can be called. How Has This Been Tested? Ran the changes on Arista7050cx3 switch, making changes inside the container. Co-authored-by: xinyu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug coming from #175 when asic is removed due to card getting offline (before it was online).
The change works on real hw + unit test.