Fix test_route_flow_counter#9958
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Sep 16, 2023
Merged
Conversation
Independent pytest fixtures can run even if one causes the test function to skip. The `clear_route_flow_counter` fixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 24, 2023
What is the motivation for this PR? When test_route_flow_counter is ran on unsupported platform, it fails due to clear_route_flow_counter fixture running which assumes that platform is supported. Independent pytest fixtures can run even if one causes the test function to skip. The clear_route_flow_counter fixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency. How did you do it? Added skip_if_not_supported as a dependency of clear_route_flow_counter. By doing this, if test is skipped because there is a lack of support then clear_route_flow_counter will not run. How did you verify/test it? Verified that test is skipped on unsupported platform
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 24, 2023
What is the motivation for this PR? When test_route_flow_counter is ran on unsupported platform, it fails due to clear_route_flow_counter fixture running which assumes that platform is supported. Independent pytest fixtures can run even if one causes the test function to skip. The clear_route_flow_counter fixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency. How did you do it? Added skip_if_not_supported as a dependency of clear_route_flow_counter. By doing this, if test is skipped because there is a lack of support then clear_route_flow_counter will not run. How did you verify/test it? Verified that test is skipped on unsupported platform
Collaborator
|
Cherry-pick PR to 202205: #10455 |
Collaborator
|
Cherry-pick PR to 202305: #10456 |
This was referenced Oct 24, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Oct 25, 2023
What is the motivation for this PR? When test_route_flow_counter is ran on unsupported platform, it fails due to clear_route_flow_counter fixture running which assumes that platform is supported. Independent pytest fixtures can run even if one causes the test function to skip. The clear_route_flow_counter fixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency. How did you do it? Added skip_if_not_supported as a dependency of clear_route_flow_counter. By doing this, if test is skipped because there is a lack of support then clear_route_flow_counter will not run. How did you verify/test it? Verified that test is skipped on unsupported platform
mssonicbld
pushed a commit
that referenced
this pull request
Oct 25, 2023
What is the motivation for this PR? When test_route_flow_counter is ran on unsupported platform, it fails due to clear_route_flow_counter fixture running which assumes that platform is supported. Independent pytest fixtures can run even if one causes the test function to skip. The clear_route_flow_counter fixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency. How did you do it? Added skip_if_not_supported as a dependency of clear_route_flow_counter. By doing this, if test is skipped because there is a lack of support then clear_route_flow_counter will not run. How did you verify/test it? Verified that test is skipped on unsupported platform
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? When test_route_flow_counter is ran on unsupported platform, it fails due to clear_route_flow_counter fixture running which assumes that platform is supported. Independent pytest fixtures can run even if one causes the test function to skip. The clear_route_flow_counter fixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency. How did you do it? Added skip_if_not_supported as a dependency of clear_route_flow_counter. By doing this, if test is skipped because there is a lack of support then clear_route_flow_counter will not run. How did you verify/test it? Verified that test is skipped on unsupported platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix
test_route_flow_counterwhen ran on unsupported platformsFixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When
test_route_flow_counteris ran on unsupported platform, it fails due toclear_route_flow_counterfixture running which assumes that platform is supported.Independent pytest fixtures can run even if one causes the test function to skip. The
clear_route_flow_counterfixture should not run if the test is skipped (due to lack of support) so the appropriate fixture arg should be included to mark the dependency.How did you do it?
Added
skip_if_not_supportedas a dependency ofclear_route_flow_counter. By doing this, if test is skipped because there is a lack of support thenclear_route_flow_counterwill not run.How did you verify/test it?
Verified that test is skipped on unsupported platform
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation