Optimizing the location of topology information and generating according to dut#959
Closed
Harrison-SH wants to merge 1 commit intosonic-net:masterfrom
Harrison-SH:daily-pr
Closed
Optimizing the location of topology information and generating according to dut#959Harrison-SH wants to merge 1 commit intosonic-net:masterfrom Harrison-SH:daily-pr
Harrison-SH wants to merge 1 commit intosonic-net:masterfrom
Harrison-SH:daily-pr
Conversation
…e varible of topo_file. Optimizing topology information could be generated according to the special dut.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
These changes are included in this PR: 07e1f79 [syncd] Add workaround for warm boot new objects (sonic-net#959) 50fd353 Fix the option missing in kernel config issue (sonic-net#956) e77503c [syncd] Comparison logic workaround for empty buffer profile (sonic-net#906) (sonic-net#941)
Collaborator
|
This PR has been open since June 2019 (~7 years). The codebase — particularly Additionally, a few concerns with the approach:
Recommend closing this PR as stale. If the feature is still needed, a fresh PR against the current codebase would be more appropriate. |
Collaborator
|
Closing the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Optimizing the location of topology information to be specified by the varible of topo_file.
Optimizing topology information could be generated according to the special dut.
Signed-off-by: Harrison-hu [email protected]
Type of change
Approach
Within testbed-cli.sh. Setting the location of topology files to topo_file.
Within testbed_add_vm_topology.yml ... . instead of vars/topo_{{ topo }}.yml with {{ topo_file }}.
Within testbed-cli.sh. If user has defined the topology information with the dut. Use the topology
information as topo_file
How did you verify/test it?