[action] [PR:9199] Recover default acl rules if necessary in module crm/test_crm.py. #9225
Merged
mssonicbld merged 1 commit intosonic-net:202305from Aug 2, 2023
Merged
Conversation
…onic-net#9199) Description of PR In module crm/test_crm.py, it will delete all acl rules after test running. But of DUT has original data plan acl rules, they are also deleted, and will cause inconsistent between previous running config and current running config. In this PR, we will recover original acl rules if exist. What is the motivation for this PR? In module crm/test_crm.py, it will delete all acl rules after test running. But of DUT has original data plan acl rules, they are also deleted, and will cause inconsistent between previous running config and current running config. In this PR, we will recover original acl rules if exist. How did you do it? Add a fixture to record the original data plan acl rules and recover them if exist. How did you verify/test it? 05:46:38 conftest.core_dump_and_config_check L1767 INFO | Collecting running config after test on str2-7050qx-32s-acs-02 Signed-off-by: Yutong Zhang <[email protected]>
6 tasks
Collaborator
Author
|
Original PR: #9199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In module
crm/test_crm.py, it will delete all acl rules after test running. But of DUT has original data plan acl rules, they are also deleted, and will cause inconsistent between previous running config and current running config. In this PR, we will recover original acl rules if exist.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In module
crm/test_crm.py, it will delete all acl rules after test running. But of DUT has original data plan acl rules, they are also deleted, and will cause inconsistent between previous running config and current running config. In this PR, we will recover original acl rules if exist.How did you do it?
Add a fixture to record the original data plan acl rules and recover them if exist.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation