Skip to content

Improve vxlan decap test. Make a test after vxlan removal#914

Merged
pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/vxlan_remove
May 16, 2019
Merged

Improve vxlan decap test. Make a test after vxlan removal#914
pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov:pavelsh/vxlan_remove

Conversation

@pavel-shirshov
Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

  1. Add one extra test case: remove vxlan configuration and check that data plane made the change
  2. Adjusted timeout parameter. Sometimes we lost first packet, because SONiC takes more than 0.1 second to insert FDB entry.

How did you verify/test it?

ansible-playbook test_sonic.yml -i str --limit sonic-device --vault-password-file password.txt -e testcase_name=vxlan_decap -e testbed_name=testbed-1

Any platform specific information?

Supported testbed topology if it's a new test case?

T0

Documentation

Copy link
Copy Markdown
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pavel-shirshov pavel-shirshov merged commit a1e378c into sonic-net:master May 16, 2019
@pavel-shirshov pavel-shirshov deleted the pavelsh/vxlan_remove branch May 16, 2019 01:59
yxieca pushed a commit that referenced this pull request Aug 8, 2019
* Improve vxlan decap test. Make a test after vxlan removal

* Increase timeout time for vxlan-decap test

* Use docker exec to run redis-cli
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Submodule src/sonic-utilities 7a2348c..4488525:
  > use vlan members (sonic-net#542)
  > [sonic_installer] If asked to install an image which is already installed, simply set as default (sonic-net#534)

Submodule src/sonic-swss 8246bd9..9c4ae18:
  > Ignore neighbor entry with BCAST MAC, check SAI status exists (sonic-net#914)

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Make sure db_migrator is run after all config are loaded during (sonic-net#926)
Vnet alias mapping (sonic-net#924)
Changes to make lldp show command for multi-npu platforms. (sonic-net#914)
[Mellanox] Fix thermal control issue: use natural sort for fan
status and thermal status (sonic-net#836)
[Mellanox] add document for thermal control related cli (sonic-net#832)
arawat-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Apr 9, 2026
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
https://nexthopai.atlassian.net/browse/NOS-4066
The fix simply checks for vlan interface and skips if not present.
Currently in our testbed DUTs we don't have VLAN interfaces, so skipping
the tests.
Later we can explore how to simulate vlan packets from ptf to DUT- may
be through QinQ.

Summary:
Fixes # (issue)
As described above

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement


### Back port request
- [ ] 202505
- [ ] 202511

### Approach
#### What is the motivation for this PR?
The motivation is to skip vlan based tests which are not supported in
the current testbeds.

#### How did you do it?
--

#### How did you verify/test it?
Ran the specific test on t1-8 topo gold404

```
 tests/qos/test_qos_sai.py::TestQosSai.testQosSaiDot1pQueueMapping[single_asic] s20% ██
 tests/qos/test_qos_sai.py::TestQosSai.testQosSaiDot1pQueueMapping[single_dut_multi_asic] s40% ████
 tests/qos/test_qos_sai.py::TestQosSai.testQosSaiDot1pQueueMapping[multi_dut_longlink_to_shortlink] s60% ██████
 tests/qos/test_qos_sai.py::TestQosSai.testQosSaiDot1pQueueMapping[multi_dut_shortlink_to_shortlink] s80% ████████
 tests/qos/test_qos_sai.py::TestQosSai.testQosSaiDot1pQueueMapping[multi_dut_shortlink_to_longlink] s100% ██████████
------------------ generated xml file: /tmp/test-logs/tr.xml -------------------
```

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants