Fixing topo issue in Copp skip test#8827
Merged
abdosi merged 1 commit intosonic-net:masterfrom Mar 25, 2024
Merged
Conversation
Collaborator
Author
|
FYI @abdosi |
Contributor
|
can you please check if we need this PR still ? |
Collaborator
Author
|
@abdosi we still are hitting this issue, it slows down the entire run during nightly run. |
abdosi
approved these changes
Mar 25, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
topo was used instead of topo_type which was causing the condition to fail.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
topo was used instead of topo_type which was causing the condition to fail.
How did you do it?
used topo_type instead of topo
How did you verify/test it?
Verified for T2 profile
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation