[chassis] update the T3 device type in the minigraph#8779
Merged
arlakshm merged 2 commits intosonic-net:masterfrom Jul 6, 2023
Merged
[chassis] update the T3 device type in the minigraph#8779arlakshm merged 2 commits intosonic-net:masterfrom
arlakshm merged 2 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
add @kenneth-arista @ysmanman @ansrajpu-git for viz.. |
abdosi
approved these changes
Jul 3, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 10, 2023
Summary: Fixes sonic-net#8700 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 201911 202012 [x ] 202205 Approach What is the motivation for this PR? The cable length is calculated based on the neighbor type and device type. In the T2 topology the uplink neighbor type in the minigraph is defined as CoreRouter. This causes the device to pick incorrect cable length for uplink neighbors. Example https://github.com/sonic-net/sonic-buildimage/blob/aa46167fdd09b5f973d6c39529715ad75a2a58ec/device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers_defaults_t2.j2#L3-L9 How did you do it? This PR fixes the neighbor type of uplink neighbors to be set to RegionalHub or AZNGHub to match the values defined in the buffer_default_t2.j2
Collaborator
|
Cherry-pick PR to 202205: #8868 |
5 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 10, 2023
Summary: Fixes #8700 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 201911 202012 [x ] 202205 Approach What is the motivation for this PR? The cable length is calculated based on the neighbor type and device type. In the T2 topology the uplink neighbor type in the minigraph is defined as CoreRouter. This causes the device to pick incorrect cable length for uplink neighbors. Example https://github.com/sonic-net/sonic-buildimage/blob/aa46167fdd09b5f973d6c39529715ad75a2a58ec/device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers_defaults_t2.j2#L3-L9 How did you do it? This PR fixes the neighbor type of uplink neighbors to be set to RegionalHub or AZNGHub to match the values defined in the buffer_default_t2.j2
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
Contributor
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Summary: Fixes sonic-net#8700 Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 201911 202012 [x ] 202205 Approach What is the motivation for this PR? The cable length is calculated based on the neighbor type and device type. In the T2 topology the uplink neighbor type in the minigraph is defined as CoreRouter. This causes the device to pick incorrect cable length for uplink neighbors. Example https://github.com/sonic-net/sonic-buildimage/blob/aa46167fdd09b5f973d6c39529715ad75a2a58ec/device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers_defaults_t2.j2#L3-L9 How did you do it? This PR fixes the neighbor type of uplink neighbors to be set to RegionalHub or AZNGHub to match the values defined in the buffer_default_t2.j2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #8700
Type of change
Back port request
Approach
What is the motivation for this PR?
The cable length is calculated based on the neighbor type and device type. In the T2 topology the uplink neighbor type in the minigraph is defined as CoreRouter. This causes the device to pick incorrect cable length for uplink neighbors.
Example
https://github.com/sonic-net/sonic-buildimage/blob/aa46167fdd09b5f973d6c39529715ad75a2a58ec/device/arista/x86_64-arista_7800r3a_36d2_lc/Arista-7800R3A-36D2-C36/0/buffers_defaults_t2.j2#L3-L9
How did you do it?
This PR fixes the neighbor type of uplink neighbors to be set to
RegionalHuborAZNGHubto match the values defined in the buffer_default_t2.j2How did you verify/test it?
generate minigraph for T2 topo
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation