Merged
Conversation
XuChen-MSFT
approved these changes
Jun 16, 2023
Contributor
|
@bingwang-ms , Can you help to cherry pick to master branch and 202305 branch?
|
7 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 26, 2023
What is the motivation for this PR? 7050 dualtor 's pcbb xoff testcase fail, because of threshold is incorrect How did you do it? qos_param_generator.py don't support test_tunnel_qos_remap.py yet. so directly update threshold , like previous PR #8624 How did you verify/test it? Any platform specific information?
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 26, 2023
What is the motivation for this PR? 7050 dualtor 's pcbb xoff testcase fail, because of threshold is incorrect How did you do it? qos_param_generator.py don't support test_tunnel_qos_remap.py yet. so directly update threshold , like previous PR sonic-net#8624 How did you verify/test it? Any platform specific information?
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 26, 2023
What is the motivation for this PR? 7050 dualtor 's pcbb xoff testcase fail, because of threshold is incorrect How did you do it? qos_param_generator.py don't support test_tunnel_qos_remap.py yet. so directly update threshold , like previous PR #8624 How did you verify/test it? Any platform specific information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to fix
test_xoff_for_pcbbfor202205branch.Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to fix
test_xoff_for_pcbbfor202205branch.How did you do it?
Update
pkts_num_trig_pfcandpkts_num_trig_ingr_drpinqos.yml.How did you verify/test it?
Verified by running
test_xoff_for_pcbbon a dualtor testbedAny platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation