Revert "Improved error handling when not all Interfaces are up"#848
Merged
liat-grozovik merged 1 commit intomasterfrom Mar 31, 2019
Merged
Revert "Improved error handling when not all Interfaces are up"#848liat-grozovik merged 1 commit intomasterfrom
liat-grozovik merged 1 commit intomasterfrom
Conversation
This reverts commit 2ab494e.
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…sonic-net#848) Cherry pick sonic-net#20766 to 202503 branch. After ansible >= 2.14, custom modules are executed on the managed node (or in an execution environment container) that only contains the runtime bits Ansible intentionally ships there (mainly ansible.module_utils plus Python stdlib). Controller‑only internals like ansible.inventory.manager and ansible.parsing.dataloader are not present. So importing them on the remote side is fundamentally unsupported now. This change removed the code of importing ansible API in the testbed_vm_info.py customized module. Then this module can be executed in sonic-mgmt docker using ansible >= 2.14.
arawat-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Apr 9, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes NOS-2409 (Add copp stats show command support). ### Type of change mgmt tests for show copp stats - using pre-existing SAI api calls to get policer stats per trap group and verifying it. <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? The tests are added as part of the feature commit for NOS-2409 which adds support to show policer stats per trap group. This leverages existing `sai_get_policer_stats` API to get statistics for red, green and yellow packets. The PRs for reference [sonic-buildimage sonic-net#2831](nexthop-ai/private-sonic-buildimage#2831) , [sonic-swss sonic-net#277 ](nexthop-ai/private-sonic-swss#277) and [sonic-utilities sonic-net#217 ](https://github.com/nexthop-ai/private-sonic-utilities/pull/217/changes) #### How did you do it? The tests are for one vs multi asic, testing with traffic for copp stats increments in green, yellow and red packets. #### How did you verify/test it? Unit tests have been added and verified, these are sonic-mgmt tests to be run. Sonic-mgmt tests were verified on xgs platforms, dnx platforms to be skipped. #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #815