Closed
Conversation
abdosi
reviewed
May 17, 2023
| for asic in active_asics: | ||
| service_list += asic.get_critical_services() | ||
| if asic: | ||
| service_list += asic.get_critical_services() |
Contributor
There was a problem hiding this comment.
why we need this active_Asic should only have fabric asics that are detected . see above logic
Contributor
Author
|
@abdosi , You are right. I saw a misconfig in the lab file after debugging. The lab entry was asics_present: [0,1,2,3,4,5] , while in fact the chassis had the fabric cards in slots: 1,2, and 3 (not 0, 1, and 2). This is what caused the None for some of the RP asics. I misread the entry and raised this PR. Closing it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For cisco-8000, the RP presents an asic for every fabric card that is present. If there is no fabric card in a slot, the asic is returned as None. It is ok to ignore that, since it is not used by RP anyways.