[DualTor][Mellanox]Fix dualtor mac move test for Mellanox platforms#7647
Merged
yxieca merged 1 commit intosonic-net:masterfrom Mar 10, 2023
Merged
[DualTor][Mellanox]Fix dualtor mac move test for Mellanox platforms#7647yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Skip the check on active tor after fdb is flushed on Mellanox platforms, because the check expects the traffic should be dropped when there is no fdb entry. But on Mellanox platforms the traffic will be flooded in the vlan, not dropped. Change-Id: Ibb6edfe552d0623f297c65301bcbc61465786fb6
Collaborator
|
@bingwang-ms could you please review or assign someone to do so? |
Collaborator
|
@bingwang-ms @yxieca could you please help to review / merge? |
bingwang-ms
approved these changes
Mar 9, 2023
Collaborator
Please confirm if we also need this workaround in |
Collaborator
|
I think we need this change in 202205 but not 202012. |
wangxin
pushed a commit
that referenced
this pull request
Mar 10, 2023
Skip the check on active tor after fdb is flushed on Mellanox platforms, because the check expects the traffic should be dropped when there is no fdb entry. But on Mellanox platforms the traffic will be flooded in the vlan, not dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ibb6edfe552d0623f297c65301bcbc61465786fb6
Description of PR
Summary:
In the test test_orchagent_mac_move.py, the last check is to verify after fdb is flushed, the traffic to the new neighbor should be dropped due to no fdb entry of the neighbor in the Vlan. However, on Mellanox platforms, the behavior is flooding the traffic instead of dropping it, which will cause the check to fail.
Since this is a valid behavior on Mellanox switches, need to skip this check in this case.
Type of change
Back port request
Approach
What is the motivation for this PR?
Make test test_orchagent_mac_move.py pass on Mellanox platforms.
How did you do it?
Skip the the check on active tor after fdb is flushed on Mellanox platforms.
How did you verify/test it?
By automation, test passed.
Any platform specific information?
The fix is only for Mellanox platforms.
Supported testbed topology if it's a new test case?
Documentation