Skip to content

[test]: Fix typo#743

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:are
Dec 4, 2018
Merged

[test]: Fix typo#743
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:are

Conversation

@stcheng
Copy link
Copy Markdown
Contributor

@stcheng stcheng commented Dec 4, 2018

Signed-off-by: Shu0T1an ChenG [email protected]

Signed-off-by: Shu0T1an ChenG <[email protected]>
@stcheng stcheng merged commit 35ca7fd into sonic-net:master Dec 4, 2018
@stcheng stcheng deleted the are branch December 4, 2018 00:14
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Oct 27, 2025
sonic-net#743)

What is the motivation for this PR?
Some deployment tasks such as VM network create/destroy and topology
bind/unbind were previously executed in serial, which caused long
deployment time when the neighbor number is large. This PR introduces
parallel execution for these
time-consuming tasks using ansible async, reducing overall deployment
time.

How did you do it?
This PR introduces parallel execution for these time-consuming tasks
using ansible async, reducing overall deployment time.

How did you verify/test it?
I have tested on 256 ports testbed and some testbeds in bjw, and there
are no issues.
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…D automatically (#25634)

#### Why I did it
src/sonic-platform-daemons
```
* 9020d38 - (HEAD -> master, origin/master, origin/HEAD) psud: Handle Redis BUSY errors gracefully (sonic-net#743) (2 hours ago) [Vasundhara Volam]
* 177451e - chassis_db_init: add exception handling for HW info fetch (sonic-net#740) (25 hours ago) [LinJin23]
* 2bc0f21 - [xcvrd] Arm DP_ACTIVATE timer in CMIS_STATE_DP_TXON using max of DPInitDuration and MaxDPTxTurnOnDuration (sonic-net#751) (26 hours ago) [pnakka28]
* fa2f491 - Read SFP temperature from TRANSCEIVER_DOM_TEMPERATURE table (sonic-net#747) (2 days ago) [Vasundhara Volam]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Pterosaur pushed a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 26, 2026
Pterosaur added a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 26, 2026
Pterosaur pushed a commit to Pterosaur/sonic-mgmt that referenced this pull request Mar 26, 2026
arawat-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Apr 9, 2026
…-net#743)

### Description of PR

Summary: When checking for interface name in SonicHost VM, remove hyphen
(`-`) from the name
Fixes https://nexthopai.atlassian.net/browse/NOS-3542

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement


### Back port request
- [x] 202505

### Approach
#### What is the motivation for this PR?

After nexthop-ai/private-sonic-mgmt#720, the
tests that use EOS VM passed. But then, the problem arose for SonicHost
VM. This PR is to make it work for both SonicHost VM and EOS VM.

#### How did you do it?

Keep the original `intf = intf.replace("-", "")` but only when the VM is
SONiC.

#### How did you verify/test it?

I looked at [a test
log](http://qp/testruns/outputs/2025/12/21/1766358133292177.test.log)
from Hummingbird, the vmhost facts showed "PortChannel1" without the
hyphen:

<img width="281" height="666" alt="Screenshot 2025-12-22 at 4 34 29 PM"
src="https://github.com/user-attachments/assets/0fa4f5a6-865c-4c68-90e8-f3d08f8a7418"
/>

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants