[backend] Modify sub port testcases to use common acl helpers by neethajohn · Pull Request #6687 · sonic-net/sonic-mgmt

neethajohn · 2022-10-31T23:56:10Z

Signed-off-by: Neetha John [email protected]

Description of PR

Modify sub port testcases to use common backend acl helpers added as part of #6686

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205

How did you verify/test it?

Ran the sub port testcases with this change and all cases passed

============================= test session starts ==============================
platform linux2 -- Python 2.7.17, pytest-4.6.5, py-1.10.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/nejo_n/sonic-mgmt-int/tests, inifile: pytest.ini
plugins: forked-1.3.0, metadata-1.11.0, xdist-1.28.0, html-1.22.1, repeat-0.9.1, allure-pytest-2.8.22, ansible-2.2.2
collecting ... /usr/local/lib/python2.7/dist-packages/ansible/parsing/vault/__init__.py:44: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.
  from cryptography.exceptions import InvalidSignature
collected 29 items                                                             

sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_valid_vlan[port] PASSED [  3%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_valid_vlan[port_in_lag] PASSED [  6%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_invalid_vlan[port] PASSED [ 10%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_invalid_vlan[port_in_lag] PASSED [ 13%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_untagged_packet_not_routed[port] PASSED [ 17%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_admin_status_down_disables_forwarding[port] PASSED [ 20%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_admin_status_down_disables_forwarding[port_in_lag] PASSED [ 24%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_max_numbers_of_sub_ports[port] PASSED [ 27%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_max_numbers_of_sub_ports[port_in_lag] PASSED [ 31%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_mtu_inherited_from_parent_port[port] PASSED [ 34%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_mtu_inherited_from_parent_port[port_in_lag] PASSED [ 37%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_vlan_config_impact[port] PASSED [ 41%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_vlan_config_impact[port_in_lag] PASSED [ 44%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[same-port-TCP-UDP-ICMP] PASSED [ 48%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[same-port_in_lag-TCP-UDP-ICMP] PASSED [ 51%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[different-port-TCP-UDP-ICMP] PASSED [ 55%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[different-port_in_lag-TCP-UDP-ICMP] PASSED [ 58%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_unaffected_by_sub_ports_removal[same-TCP-UDP-ICMP-PORT] PASSED [ 62%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_unaffected_by_sub_ports_removal[different-TCP-UDP-ICMP-PORT] PASSED [ 65%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[svi-port-TCP-UDP-ICMP] PASSED [ 68%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[svi-port_in_lag-TCP-UDP-ICMP] PASSED [ 72%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[l3-port-TCP-UDP-ICMP] PASSED [ 75%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[l3-port_in_lag-TCP-UDP-ICMP] PASSED [ 79%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[same-port] PASSED [ 82%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[same-port_in_lag] PASSED [ 86%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[different-port] PASSED [ 89%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[different-port_in_lag] PASSED [ 93%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_balancing_sub_ports[port] PASSED [ 96%]
sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_balancing_sub_ports[port_in_lag] PASSED [100%]

Signed-off-by: Neetha John <[email protected]>

azure-pipelines · 2022-10-31T23:56:55Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/sub_port_interfaces/conftest.py:57:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:62:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:70:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:72:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:73:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:74:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:76:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:78:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:79:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:81:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:137:121: E501 line too long (127 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

neethajohn · 2022-11-04T21:04:40Z

/azp run

azure-pipelines · 2022-11-04T21:04:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2022-11-04T21:05:21Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/sub_port_interfaces/conftest.py:57:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:62:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:70:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:72:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:73:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:74:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:76:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:78:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:79:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:81:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:137:121: E501 line too long (127 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

neethajohn · 2022-11-07T21:48:39Z

/azp run

azure-pipelines · 2022-11-07T21:48:48Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2022-11-07T21:49:26Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/sub_port_interfaces/conftest.py:57:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:62:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:70:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:72:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:73:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:74:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:76:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:78:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:79:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:81:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:137:121: E501 line too long (127 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

neethajohn · 2022-11-08T23:16:32Z

/azp run

azure-pipelines · 2022-11-08T23:16:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2022-11-08T23:17:21Z

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/sub_port_interfaces/conftest.py:57:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:62:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:70:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:72:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:73:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:74:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:76:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:78:4: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:79:8: E111 indentation is not a multiple of 4 tests/sub_port_interfaces/conftest.py:81:1: E302 expected 2 blank lines, found 1 tests/sub_port_interfaces/conftest.py:137:121: E501 line too long (127 > 120 characters) ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Neetha John <[email protected]> Modify sub port testcases to use common backend acl helpers added as part of #6686 How did you verify/test it? Ran the sub port testcases with this change and all cases passed ============================= test session starts ============================== platform linux2 -- Python 2.7.17, pytest-4.6.5, py-1.10.0, pluggy-0.13.1 ansible: 2.8.12 rootdir: /var/nejo_n/sonic-mgmt-int/tests, inifile: pytest.ini plugins: forked-1.3.0, metadata-1.11.0, xdist-1.28.0, html-1.22.1, repeat-0.9.1, allure-pytest-2.8.22, ansible-2.2.2 collecting ... /usr/local/lib/python2.7/dist-packages/ansible/parsing/vault/__init__.py:44: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release. from cryptography.exceptions import InvalidSignature collected 29 items sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_valid_vlan[port] PASSED [ 3%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_valid_vlan[port_in_lag] PASSED [ 6%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_invalid_vlan[port] PASSED [ 10%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_packet_routed_with_invalid_vlan[port_in_lag] PASSED [ 13%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_untagged_packet_not_routed[port] PASSED [ 17%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_admin_status_down_disables_forwarding[port] PASSED [ 20%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_admin_status_down_disables_forwarding[port_in_lag] PASSED [ 24%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_max_numbers_of_sub_ports[port] PASSED [ 27%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_max_numbers_of_sub_ports[port_in_lag] PASSED [ 31%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_mtu_inherited_from_parent_port[port] PASSED [ 34%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_mtu_inherited_from_parent_port[port_in_lag] PASSED [ 37%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_vlan_config_impact[port] PASSED [ 41%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_vlan_config_impact[port_in_lag] PASSED [ 44%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[same-port-TCP-UDP-ICMP] PASSED [ 48%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[same-port_in_lag-TCP-UDP-ICMP] PASSED [ 51%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[different-port-TCP-UDP-ICMP] PASSED [ 55%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports[different-port_in_lag-TCP-UDP-ICMP] PASSED [ 58%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_unaffected_by_sub_ports_removal[same-TCP-UDP-ICMP-PORT] PASSED [ 62%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_unaffected_by_sub_ports_removal[different-TCP-UDP-ICMP-PORT] PASSED [ 65%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[svi-port-TCP-UDP-ICMP] PASSED [ 68%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[svi-port_in_lag-TCP-UDP-ICMP] PASSED [ 72%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[l3-port-TCP-UDP-ICMP] PASSED [ 75%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_routing_between_sub_ports_and_port[l3-port_in_lag-TCP-UDP-ICMP] PASSED [ 79%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[same-port] PASSED [ 82%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[same-port_in_lag] PASSED [ 86%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[different-port] PASSED [ 89%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_tunneling_between_sub_ports[different-port_in_lag] PASSED [ 93%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_balancing_sub_ports[port] PASSED [ 96%] sub_port_interfaces/test_sub_port_interfaces.py::TestSubPorts::test_balancing_sub_ports[port_in_lag] PASSED [100%]

Modify sub port testcases to use common acl helpers

9aa0a9d

Signed-off-by: Neetha John <[email protected]>

neethajohn added Request for 202012 branch Request for 202205 branch labels Oct 31, 2022

neethajohn requested a review from yejianquan October 31, 2022 23:56

yxieca approved these changes Nov 1, 2022

View reviewed changes

neethajohn merged commit 55995eb into sonic-net:master Nov 14, 2022

neethajohn deleted the update_sub_port branch November 14, 2022 19:29

wangxin added the Included in 202012 branch label Nov 15, 2022

wangxin added the Included in 202205 branch label Nov 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backend] Modify sub port testcases to use common acl helpers#6687

[backend] Modify sub port testcases to use common acl helpers#6687
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:update_sub_port

neethajohn commented Oct 31, 2022

Uh oh!

azure-pipelines bot commented Oct 31, 2022

Uh oh!

neethajohn commented Nov 4, 2022

Uh oh!

azure-pipelines bot commented Nov 4, 2022

Uh oh!

azure-pipelines bot commented Nov 4, 2022

Uh oh!

neethajohn commented Nov 7, 2022

Uh oh!

azure-pipelines bot commented Nov 7, 2022

Uh oh!

azure-pipelines bot commented Nov 7, 2022

Uh oh!

neethajohn commented Nov 8, 2022

Uh oh!

azure-pipelines bot commented Nov 8, 2022

Uh oh!

azure-pipelines bot commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

neethajohn commented Oct 31, 2022

Description of PR

Type of change

Back port request

How did you verify/test it?

Uh oh!

azure-pipelines bot commented Oct 31, 2022

Uh oh!

neethajohn commented Nov 4, 2022

Uh oh!

azure-pipelines bot commented Nov 4, 2022

Uh oh!

azure-pipelines bot commented Nov 4, 2022

Uh oh!

neethajohn commented Nov 7, 2022

Uh oh!

azure-pipelines bot commented Nov 7, 2022

Uh oh!

azure-pipelines bot commented Nov 7, 2022

Uh oh!

neethajohn commented Nov 8, 2022

Uh oh!

azure-pipelines bot commented Nov 8, 2022

Uh oh!

azure-pipelines bot commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants