[grpc] update GRPC configuration with sed#6508
Merged
yxieca merged 1 commit intosonic-net:masterfrom Oct 10, 2022
Merged
Conversation
Signed-off-by: Ying Xie <[email protected]>
vdahiya12
approved these changes
Oct 10, 2022
yxieca
added a commit
that referenced
this pull request
Oct 10, 2022
What is the motivation for this PR? The original code updated the grpc configuration and left a file with unexpected format. Causing the ycabled module unable to initialize. How did you do it? Use more direct way (sed) to update the configuration file. How did you verify/test it? Deploy minigraph on active-active testbed. Signed-off-by: Ying Xie [email protected]
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
What is the motivation for this PR? The original code updated the grpc configuration and left a file with unexpected format. Causing the ycabled module unable to initialize. How did you do it? Use more direct way (sed) to update the configuration file. How did you verify/test it? Deploy minigraph on active-active testbed. Signed-off-by: Ying Xie [email protected]
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
What is the motivation for this PR? The original code updated the grpc configuration and left a file with unexpected format. Causing the ycabled module unable to initialize. How did you do it? Use more direct way (sed) to update the configuration file. How did you verify/test it? Deploy minigraph on active-active testbed. Signed-off-by: Ying Xie [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The original code updated the grpc configuration and left a file with unexpected format. Causing the ycabled module unable to initialize.
How did you do it?
Use more direct way (sed) to update the configuration file.
How did you verify/test it?
Deploy minigraph on active-active testbed.
Signed-off-by: Ying Xie [email protected]