tacacs: test_ro_disk: Fix possible failure which could prevent reboot#5288
Merged
wangxin merged 1 commit intosonic-net:masterfrom Mar 8, 2022
Merged
tacacs: test_ro_disk: Fix possible failure which could prevent reboot#5288wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
…eboot. Leave reboot as the only command in finally. 2) Don't use duthost to fetch as that could fail, when test takes longer.
wangxin
approved these changes
Mar 8, 2022
renukamanavalan
added a commit
to renukamanavalan/sonic-mgmt
that referenced
this pull request
Mar 8, 2022
…sonic-net#5288) What is the motivation for this PR? tacacs: test_ro_disk: Fix possible failure which could prevent reboot How did you do it? 1. Don't add any commands to "finally" clause in main test as any failure could prevent reboot. Leave reboot as the only command in finally. 2. Don't use duthost to fetch as that could fail, when test takes longer. How did you verify/test it? Ran the test in two testbeds. Both success & failed scenarios. Simulated failed scenario, by removing disk_check call from monit's conf.
wangxin
pushed a commit
that referenced
this pull request
Mar 8, 2022
…#5288) What is the motivation for this PR? tacacs: test_ro_disk: Fix possible failure which could prevent reboot How did you do it? 1. Don't add any commands to "finally" clause in main test as any failure could prevent reboot. Leave reboot as the only command in finally. 2. Don't use duthost to fetch as that could fail, when test takes longer. How did you verify/test it? Ran the test in two testbeds. Both success & failed scenarios. Simulated failed scenario, by removing disk_check call from monit's conf.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Don't add any commands to "finally" clause in main test as any failure could prevent reboot. Leave reboot as the only command in finally.
Don't use duthost to fetch as that could fail, when test takes longer.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Ran the test in two testbeds. Both success & failed scenarios. Simulated failed scenario, by removing disk_check call from monit's conf.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation