Merged
Conversation
Add a few improvements: 1. For `test_basic_fib`: 1.1 Add back the logic to toggle the ports to random side. 1.2 Use fixture `toggle_all_simulator_ports_to_random_side` to do the toggle instead and add extra check `_check_mux_status_consistency` to ensure the mux status from the DUTs and mux simulator is consistent after the toggle. 2. For `test_hash`: 2.1 Use `toggle_all_simulator_ports_to_rand_selected_tor` to do the toggle because it has check to verify the toggle. Signed-off-by: Longxiang Lyu <[email protected]>
|
This pull request introduces 3 alerts when merging 4b1f66f into 768b672 - view on LGTM.com new alerts:
|
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
improve_test_fib_dualtor
branch
from
b5b0da8 to
cec65ca
Compare
Signed-off-by: Longxiang Lyu <[email protected]>
Collaborator
Author
|
/AZP run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Sep 11, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Approach What is the motivation for this PR? Improve test_fib stability over dualtor testbed How did you do it? Add a few improvements: For test_basic_fib: 1.1 Add back the logic to toggle the ports to random side. 1.2 Use fixture toggle_all_simulator_ports_to_random_side to do the toggle instead and add extra check _check_mux_status_consistency to ensure the mux status from the DUTs and mux simulator is consistent after the toggle. For test_hash: 2.1 Use toggle_all_simulator_ports_to_rand_selected_tor to do the toggle because it has check to verify the toggle. Signed-off-by: Longxiang Lyu [email protected] How did you verify/test it? Run it over dualtor, t0 and t1 testbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes sonic-net/sonic-buildimage#8519
Fixes sonic-net/sonic-buildimage#8103
Type of change
Back port request
Approach
What is the motivation for this PR?
Improve
test_fibstability over dualtor testbedHow did you do it?
Add a few improvements:
For
test_basic_fib:1.1 Add back the logic to toggle the ports to random side.
1.2 Use fixture
toggle_all_simulator_ports_to_random_sideto do thetoggle instead and add extra check
_check_mux_status_consistencytoensure the mux status from the DUTs and mux simulator is consistent
after the toggle.
For
test_hash:2.1 Use
toggle_all_simulator_ports_to_rand_selected_torto do thetoggle because it has check to verify the toggle.
Signed-off-by: Longxiang Lyu [email protected]
How did you verify/test it?
Run it over dualtor, t0 and t1 testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation