Modifying tests to adapt to new config reload system checks#3657
Merged
yxieca merged 5 commits intosonic-net:masterfrom Jun 22, 2021
Merged
Modifying tests to adapt to new config reload system checks#3657yxieca merged 5 commits intosonic-net:masterfrom
yxieca merged 5 commits intosonic-net:masterfrom
Conversation
Cosmetic changes Added force option case Addressing comments Adding changes for backward compatibility Test fixes Fixed import
dgsudharsan
force-pushed
the
config_reload_fix
branch
from
2492c59 to
acc2e41
Compare
|
This pull request introduces 2 alerts when merging acc2e41 into 6a4da3c - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ca7a3b9 into 6a4da3c - view on LGTM.com new alerts:
|
Merged
4 tasks
Contributor
Author
liat-grozovik
approved these changes
Jun 20, 2021
jleveque
suggested changes
Jun 21, 2021
jleveque
approved these changes
Jun 21, 2021
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Looks good to me. I would like someone from @Azure/sonic-fundamentals to review, as well.
yxieca
approved these changes
Jun 22, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…t#3657) Description of PR Modify sonic-mgmt test cases to handle new config reload behavior. Config reload will perform system checks before proceeding. If the listed system checks fail config reload will not execute. Summary: Approach What is the motivation for this PR? To enhance the test cases as per new config reload behavior. How did you do it? Added system check in tests before executing config reload command so that it would not fail. Additionally add new test case to validate config reload command behavior. How did you verify/test it? Run config reload platform tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Modify sonic-mgmt test cases to handle new config reload behavior. Config reload will perform system checks before proceeding. If the listed system checks fail config reload will not execute.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To enhance the test cases as per new config reload behavior.
How did you do it?
Added system check in tests before executing config reload command so that it would not fail. Additionally add new test case to validate config reload command behavior.
How did you verify/test it?
Run config reload platform tests.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation