Skip to content

[qos] Enable PG Shared Watermark tests on Th2#3424

Merged
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:enable_pgwm_th2
May 3, 2021
Merged

[qos] Enable PG Shared Watermark tests on Th2#3424
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:enable_pgwm_th2

Conversation

@neethajohn
Copy link
Copy Markdown
Contributor

Signed-off-by: Neetha John [email protected]

Description of PR

Based on vendor recommendation, updated the pg shared wm tests to read only the shared watermark. With this method, pg shared wm can be run on Th2

Summary:
Fixes #1626

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

How did you verify/test it?

Ran the test with the changes on Th2 and Mellanox and it passed

Copy link
Copy Markdown
Contributor

@smaheshm smaheshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@neethajohn neethajohn merged commit 7baf711 into sonic-net:master May 3, 2021
@neethajohn neethajohn deleted the enable_pgwm_th2 branch May 3, 2021 15:57
saravanansv pushed a commit to saravanansv/sonic-mgmt that referenced this pull request May 6, 2021
Based on vendor recommendation, updated the pg shared wm tests to read only the shared watermark. With this method, pg shared wm can be run on Th2. Fixes sonic-net#1626

Signed-off-by: Neetha John <[email protected]>

How did you verify/test it?
Ran the test with the changes on Th2 and Mellanox and it passed
vmittal-msft pushed a commit to vmittal-msft/sonic-mgmt that referenced this pull request Sep 28, 2021
Based on vendor recommendation, updated the pg shared wm tests to read only the shared watermark. With this method, pg shared wm can be run on Th2. Fixes sonic-net#1626

Signed-off-by: Neetha John <[email protected]>

How did you verify/test it?
Ran the test with the changes on Th2 and Mellanox and it passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QOS SAI: PG shared Watermark test cannot be run on TH2

3 participants