Move 'get_disabled_container_list' to dut_utils.py#3335
Merged
yxieca merged 2 commits intosonic-net:masterfrom Apr 15, 2021
Merged
Move 'get_disabled_container_list' to dut_utils.py#3335yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: bingwang <[email protected]>
saravanansv
pushed a commit
to saravanansv/sonic-mgmt
that referenced
this pull request
May 6, 2021
Description of PR Summary: Util get_disabled_container_list is duplicated defined in both test_container_autorestart and test_container_check. This PR move get_disabled_container_list definiton to dut_utils.py, and fix always_disabled issue. Approach What is the motivation for this PR? This PR is to move get_disabled_container_list definiton to dut_utils.py, and fix always_disabled issue. How did you do it? Please see code. How did you verify/test it? Verified on SN4600c. Signed-off-by: bingwang <[email protected]>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Description of PR Summary: Util get_disabled_container_list is duplicated defined in both test_container_autorestart and test_container_check. This PR move get_disabled_container_list definiton to dut_utils.py, and fix always_disabled issue. Approach What is the motivation for this PR? This PR is to move get_disabled_container_list definiton to dut_utils.py, and fix always_disabled issue. How did you do it? Please see code. How did you verify/test it? Verified on SN4600c. Signed-off-by: bingwang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
Description of PR
Summary:
Util
get_disabled_container_listis duplicated defined in bothtest_container_autorestartandtest_container_check.This PR move
get_disabled_container_listdefiniton to dut_utils.py, and fixalways_disabledissue.Type of change
Approach
What is the motivation for this PR?
This PR is to move
get_disabled_container_listdefiniton to dut_utils.py, and fixalways_disabledissue.How did you do it?
Please see code.
How did you verify/test it?
Verified on SN4600c.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Documentation