[Mellanox] Optimize dynamic minimum fan speed and psu fan speed test cases#3038
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 26, 2021
Merged
Conversation
3 tasks
jleveque
reviewed
Feb 25, 2021
Comment on lines
+104
to
+107
| cmd_output = str(duthost.command('show platform temperature')['stdout_lines']) | ||
| cmd_output = cmd_output.replace("u'", "").replace(',', " ") | ||
| cmd_output = re.split(r' +',cmd_output) | ||
| cmd_output.pop(0) |
Contributor
There was a problem hiding this comment.
We need to add a --json flag to the show platform temperature command (and many other commands), so that we can more easily get the proper fields in instances like this.
jleveque
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Improve test case test_dynamic_minimum_table and test_set_psu_fan_speed:
How did you do it?
How did you verify/test it?
Run the test cases with --count 20, all passed
Any platform specific information?
Mellanox
Supported testbed topology if it's a new test case?
N/A
Documentation