Skip to content

[pfc] Fix variable return type#2672

Merged
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:fix_pfc_collect
Dec 16, 2020
Merged

[pfc] Fix variable return type#2672
neethajohn merged 1 commit intosonic-net:masterfrom
neethajohn:fix_pfc_collect

Conversation

@neethajohn
Copy link
Copy Markdown
Contributor

@neethajohn neethajohn commented Dec 15, 2020 •
edited
Loading

Signed-off-by: Neetha John [email protected]

Description of PR

Fixes the error seen during test case collection introduced by #2599. Initialize the variable as a list
https://sonic-jenkins.westus2.cloudapp.azure.com/job/common/job/sonic-mgmt-testing/job/sonic-mgmt-pr/2462/consoleFull

____________________________________________________ ERROR collecting pfc/test_pfc_pause_lossless.py ______________________________________________________
/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py:286: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/local/lib/python2.7/dist-packages/pluggy/manager.py:93: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/local/lib/python2.7/dist-packages/pluggy/manager.py:87: in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
/usr/local/lib/python2.7/dist-packages/_pytest/python.py:234: in pytest_pycollect_makeitem
    res = list(collector._genfunctions(name, obj))
/usr/local/lib/python2.7/dist-packages/_pytest/python.py:410: in _genfunctions
    self.ihook.pytest_generate_tests(metafunc=metafunc)
/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py:286: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/local/lib/python2.7/dist-packages/pluggy/manager.py:93: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/local/lib/python2.7/dist-packages/pluggy/manager.py:87: in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
conftest.py:748: in pytest_generate_tests
    metafunc.parametrize("enum_dut_lossless_prio", generate_priority_lists(metafunc, 'lossless'))
/usr/local/lib/python2.7/dist-packages/_pytest/python.py:1004: in parametrize
    function_definition=self.definition,
/usr/local/lib/python2.7/dist-packages/_pytest/mark/structures.py:125: in _for_parametrize
    parameters = cls._parse_parametrize_parameters(argvalues, force_tuple)
/usr/local/lib/python2.7/dist-packages/_pytest/mark/structures.py:119: in _parse_parametrize_parameters
    ParameterSet.extract_from(x, force_tuple=force_tuple) for x in argvalues
E   TypeError: 'NoneType' object is not iterable

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

How did you verify/test it?

Tried test case collection with the fix. No longer seeing the error

@neethajohn
Fix variable return type
2526ec7 
Signed-off-by: Neetha John <[email protected]>
@neethajohn neethajohn requested review from a team and daall December 15, 2020 22:32
@neethajohn neethajohn mentioned this pull request Dec 15, 2020
Closed
@neethajohn neethajohn merged commit 094d80b into sonic-net:master Dec 16, 2020
@neethajohn neethajohn deleted the fix_pfc_collect branch December 16, 2020 04:02
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][linkmgrd][utilities][swss][swss-common][platform-daemons][li…
602ffb1 
…nux-kernel] advance submodule head (sonic-net#13906)

linkmgrd:
* 3e7a9df 2023-02-19 | [active-active] Toggle to standby if default route is missing (sonic-net#171) (HEAD -> 202205) [Longxiang Lyu]
* 8ab1b2b 2023-02-15 | [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) [Jing Zhang]
* df862ad 2023-02-11 | Fix mux config when gRPC connection is lost (sonic-net#166) [Longxiang Lyu]

utilities:
* 8aa7930c 2023-02-13 | [portstat CLI] don't print reminder if use json format (sonic-net#2670) (HEAD -> 202205, github/202205) [wenyiz2021]
* 4e3bb6fa 2023-02-21 | Add "show fabric reachability" command. (sonic-net#2672) [jfeng-arista]
* 3587a94b 2023-02-18 | [202205][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2680) [Yaqiang Zhu]
* 4f07f7f0 2023-02-10 | Skip saidump for Spine Router as this can take more than 5 sec (sonic-net#2637) (sonic-net#2671) [kenneth-arista]
* e61c5ec4 2023-02-10 | [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2669) [Yaqiang Zhu]

swss:
* 1bbf725 2023-02-14 | [Workaround] EvpnRemoteVnip2pOrch warmboot check failure (sonic-net#2626) (HEAD -> 202205) [jcaiMR]
* 380f72b 2023-02-20 | Support for tc-dot1p and tc-dscp qosmap (sonic-net#2559) [Divya Mukundan]
* dbf6fcc 2022-11-01 | Added LAG member check on addLagMember() (sonic-net#2464) [Andriy Kokhan]

swss-common:
* b31391b 2023-02-21 | Prevent sonic-db-cli generate core dump (sonic-net#749) (HEAD -> 202205) [Hua Liu]
* 16ff689 2022-12-13 | Support for TC-DOT1p qos map (sonic-net#721) [Divya Mukundan]

platform-daemons:
* fb92af4 2023-02-09 | [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) (HEAD -> 202205) [vdahiya12]

linux-kernel:
* 4e62401 2023-02-09 | Update linux kernel for hw-mgmt V.7.0020.4104 (sonic-net#305) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@dprital
[202205][submodule] Advance sonic-swss pointer (sonic-net#13949)
cf5a145 
Update sonic-swss submodule pointer to include the following:
* 3aeb4be Align watermark flow with port configuration ([sonic-net#2672](sonic-net/sonic-swss#2672))

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

+1 more reviewer

@daall daall daall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug 🐛 Pytest 🐍

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neethajohn @daall @bingwang-ms