[lldpctl patch] patch lldpctl script to work around ansible bug#2567
Merged
yxieca merged 1 commit intosonic-net:masterfrom Nov 22, 2020
Merged
[lldpctl patch] patch lldpctl script to work around ansible bug#2567yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
theasianpianist
approved these changes
Nov 21, 2020
Contributor
theasianpianist
left a comment
theasianpianist
left a comment
There was a problem hiding this comment.
Is it possible to also call these methods before/after the LLDP tests (and other tests relying on the LLDP module) so that they can pass when run manually?
Collaborator
Author
It is possible. But it has some merge conflict with another change I am making. I'll create another PR to improve. |
Ansible 2.8.12 has a bug in lldp module, when lldpctl -f keyvalue shows multiple unknown-tlvs for a single interface, it will throw exception. This change is to work around the ansible lldp module issue for the time being. Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
#### Why I did it Update for following swss commits: 96180bf - 2023-01-13 : [202012] Bfd default multiplier change (sonic-net#2615) [siqbal1986] 07506ac - 2023-01-11 : Add missing parameter to on_switch_shutdown_request method. (sonic-net#2567) [Hua Liu] 3253cc8 - 2022-11-30 : Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] f4df524 - 2023-01-11 : [orchagent]:add local_discriminator to state_db (sonic-net#2587) [Baorong Liu] f3cd02d - 2022-12-05 : [202012][muxorch] Adding case for maintaining current state (sonic-net#2500) [Nikola Dancejic]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#15887) src/sonic-swss * ed0ca898 - (HEAD -> 202205, origin/202205) Add missing parameter to on_switch_shutdown_request method. (sonic-net#2567) (34 hours ago) [Hua Liu]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#16335) #### Why I did it src/sonic-swss ``` * 16817324 - (HEAD -> 202211, origin/202211) [mux]: Fix UTs segmentation fault (sonic-net#2760) (12 hours ago) [Nazarii Hnydyn] * 0fa5d880 - [orchagent]: Handle additional SAI error conditions gracefully (sonic-net#2755) (2 days ago) [prabhataravind] * 3726aebc - [mux]: Implement rollback for failed mux switchovers (sonic-net#2714) (2 days ago) [Lawrence Lee] * a8e50e7d - [portsorch]: Set default hostif TX queue (sonic-net#2697) (2 days ago) [prabhataravind] * 0689d656 - Add missing parameter to on_switch_shutdown_request method. (sonic-net#2567) (2 days ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2558
Type of change
Approach
What is the motivation for this PR?
Ansible 2.8.12 has a bug in lldp module, when lldpctl -f keyvalue shows multiple unknown-tlvs for a single interface, it will throw
exception.
How did you do it?
This change is to work around the ansible lldp module issue for the time being.
How did you verify/test it?
Run lldp/test_lldp.py, test passes.
Run snmp/test_snmp_lldp.py. test passes.
Signed-off-by: Ying Xie [email protected]