Skip to content

Fix test_show_platform_summary for multi-asic#2502

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_show_platform_sum
Nov 11, 2020
Merged

Fix test_show_platform_summary for multi-asic#2502
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:fix_show_platform_sum

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented Nov 11, 2020

Description of PR

Summary:
Fixes # (issue)
A new field ASIC Count is added to the output of show platform summary and causes test_show_platform_summary failed. This PR addresses the issue by adding a new filed.

$ show platform summary 
Platform: x86_64-cel_seastone-r0
HwSKU: Celestica-DX010-C32
ASIC: broadcom
ASIC Count: 1

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to fix test_show_platform_summary for master branch.

How did you do it?

Add a new field ASIC Count and if the unexpected_field is exactly same with the new filed, then ignore it.

How did you verify/test it?

Veified on Arista-7260, running a 201911 image and DX010, running a master branch.

py.test --inventory ../ansible/str,../ansible/veos --host-pattern str-7260cx3-acs-2 --module-path ../ansible --testbed vms7-t0-7260-2 --testbed_file ../ansible/testbed.csv --junit-xml=tr.xml --log-cli-level warn --collect_techsupport=False --
========================================================================================= test session starts =========================================================================================
collected 1 item                                                                                                                                                                                      

platform_tests/cli/test_show_platform.py::test_show_platform_summary PASSED                                                                                                                     [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
====================================================================================== 1 passed in 12.86 seconds ======================================================================================

py.test --inventory ../ansible/str,../ansible/veos --host-pattern str-7260cx3-acs-2 --module-path ../ansible --testbed vms7-t0-7260-2 --testbed_file ../ansible/testbed.csv --junit-xml=tr.xml --log-cli-level warn --collect_techsupport=False --topology=t0,any,util platform_tests/cli/test_show_platform.py::test_show_platform_summary
========================================================================================= test session starts =========================================================================================
collected 1 item                                                                                                                                                                                      

platform_tests/cli/test_show_platform.py::test_show_platform_summary PASSED                                                                                                                     [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
====================================================================================== 1 passed in 12.86 seconds ======================================================================================

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

N/A

@bingwang-ms
Fix test_show_platform_summary for multi-asic
e2f3ca9 
A new field 'ASIC Count' is added to the output of 'show platform
summary' and causes test_show_platform_summary failed. This PR address
the issue by adding a new filed.

Signed-off-by: bingwang <[email protected]>
@bingwang-ms bingwang-ms requested a review from a team November 11, 2020 06:19
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 11, 2020

This pull request fixes 1 alert when merging e2f3ca9 into 401a796 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

lolyu
lolyu approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit 96abe3a into sonic-net:master Nov 11, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][utilities] advance submodule head (sonic-net#12871)
626530d 
utilities:
* 4b7335f 2022-11-29 | Add db_migrator_constants.py script to setup.py (sonic-net#2534) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* 8a78cf4 2022-11-23 | Port 202012 DB migration changes to newer branches (sonic-net#2515) (HEAD -> 202205) [Vaibhav Hemant Dixit]
* 0157086 2022-11-22 | [VXLAN]Fixing traceback in show remotemac when mac moves during command execution (sonic-net#2506) [Sudharsan Dhamal Gopalarathnam]
* 1f26c8c 2022-11-17 | avoid printing error if no neighbors are present (sonic-net#2502) [arlakshm]
* 2573aae 2022-11-19 | [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) [Junchao-Mellanox]
* 1d96b55 2022-11-10 | [show][muxcable] Catch port Value error exception (sonic-net#2076) (sonic-net#2486) [Isabella de Leon]
* 6ed2afb 2022-11-09 | bugfix[2024] vnet route check exit code fix. (sonic-net#2480) [siqbal1986]
* d8c49dc 2022-11-17 | Fixed SONIC_CLI_IFACE_MODE=alias show ip|ipv6 route output in default mode issue (sonic-net#2422) [Marty Y. Lok]
* 166739e 2022-11-11 | Accept 0 for queue and dscp (sonic-net#2494) (github/202205) [bingwang-ms]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lolyu lolyu lolyu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bingwang-ms @lolyu