[kvmtest]: add script to test minigraph generation#2465
Merged
lguohan merged 2 commits intosonic-net:masterfrom Nov 6, 2020
Merged
[kvmtest]: add script to test minigraph generation#2465lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
retest this please |
Signed-off-by: Guohan Lu <[email protected]>
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
theasianpianist
approved these changes
Nov 5, 2020
Contributor
theasianpianist
left a comment
theasianpianist
left a comment
There was a problem hiding this comment.
Nothing blocking, looks good overall
Signed-off-by: Guohan Lu <[email protected]>
stephenxs
reviewed
Nov 25, 2020
| - name: find interface name mapping and individual interface speed if defined | ||
| - name: find interface name mapping and individual interface speed if defined from dut | ||
| port_alias: hwsku="{{ hwsku }}" | ||
| when: deploy is defined and deploy|bool == true |
Contributor
There was a problem hiding this comment.
Hi @lguohan
It is a bit confusing to me that this is done only when the deploy is true.
IMO, deploy means whether the newly generated minigraph.xml is going to be deployed on the DUT. But here it is going to fetch the port_config.ini file from the DUT. I think they are not relevant.
Sometimes we just want to generate a minigraph file based on the port_config.ini on the DUT and will deploy the minigraph.xml in another step. In that case, this can fail the process.
Is it possible to introduce another variable to control this behavior?
Thanks
Contributor
Author
There was a problem hiding this comment.
if deploy is not defined, then go to local and get the port_alias, see line 87. this works because sonic-mgmt containers installed all sonic-device-data package as well. It is the same as DUT. Ideally, we do not need to go to the DUT to get the port alias.
Contributor
There was a problem hiding this comment.
Thanks, will try to solve it this way.
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atform-common][py-swsssdk] advance submodule head (sonic-net#13260) linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) [noaOrMlnx] swss: * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (sonic-net#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (sonic-net#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (sonic-net#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (sonic-net#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (sonic-net#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (sonic-net#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (sonic-net#655) (sonic-net#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#15320) src/sonic-utilities * ec472146 - (HEAD -> 202205, origin/202205) fix show interface neighbor expected empty issue (sonic-net#2465) (3 minutes ago) [jcaiMR] * d1f4413c - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (sonic-net#2852) (6 hours ago) [Yaqiang Zhu] * 051f28ce - [db-migrator] Fix hwsku match for 6100 and add errors when hwsku is None (sonic-net#2821) (7 hours ago) [Vaibhav Hemant Dixit]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
add script to test minigraph generation
How did you do it?
How did you verify/test it?
run scripts/testmg.sh without error
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation