config_facts enhancements for multi-asic and support in SonicAsic#2435
Merged
wangxin merged 1 commit intosonic-net:masterfrom Nov 2, 2020
Merged
config_facts enhancements for multi-asic and support in SonicAsic#2435wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
… anisble module to handle configs with no PORT definition.
wangxin
approved these changes
Nov 2, 2020
Collaborator
|
retest this please |
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…-net#11929) Include following new kernel commits: - 815cb34 [patch]: Add accept_untracked_na kernel param (sonic-net#291) - fbb76cc Remove kernel config SERIAL_8250_RUNTIME_UARTS (sonic-net#286) Introduce following SWSS commits: - eedf59d [intfmgr]: Enable `accept_untracked_na` kernel param (sonic-net#2439) - bbd4eb7 [BFD]Clean up state_db BFD entries on swss restart (sonic-net#2434) (sonic-net#2435) - aa7b546 [FDB] [202012] Fix fbdorch to properly handle syncd FDB FLUSH Notif (sonic-net#2401) - 4190c13 Support for platforms based on Clounix Networks' device (sonic-net#2399) Signed-off-by: Lawrence Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Currently, the config_facts ansible module lacks the following:
Also, we need add wrapper method for config_facts to SonicAsic class for being able to use it for multi-asic multi-dut testbeds.
How did you do it?
In config_facts ansible module:
To support no PORT metadata, in create_maps method define the port maps as empty dictionary. If 'PORT' is in the config, then only populate these port maps. So, if there is no 'PORT" in the config, return empty dictionaries.
To support 'persistent' config_facts across namespace, changed PERSISTENT_CONFIG_PATH to be '/etc/sonic/config_db{}.json". If namespace is passed, we will format PERSISTENT_CONFIG_PATH with asic_id based on the namespace, else we will format this with an empty string.
SonicAsic:
How did you verify/test it?
Tested it against pizza box, multi-asic pizza box, and chassis with multi-asic line cards and supervisor card.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation