Skip to content

Readme of PFCWD reboot and restart tests#2359

Open
SubhajitPalKeysight wants to merge 8 commits intosonic-net:masterfrom
SubhajitPalKeysight:pfc-wd-readme
Open

Readme of PFCWD reboot and restart tests#2359
SubhajitPalKeysight wants to merge 8 commits intosonic-net:masterfrom
SubhajitPalKeysight:pfc-wd-readme

Conversation

@SubhajitPalKeysight
Copy link
Copy Markdown
Contributor

Summary:

Readme of PFCWD reboot and restart tests.

Type of change

  • Test Case Documentation

@lguohan lguohan requested a review from neethajohn October 24, 2020 21:32
Comment on lines +3 to +8
- [Background](#background)
- [PFC storm detection](#pfc-storm-detection)
- [PFC storm mitigation](#pfc-storm-mitigation)
- [PFC storm restoration](#pfc-storm-restoration)
- [PFC watchdog implementation](#pfc-watchdog-implementation)
- [PFC watchdog commands on SONiC](#pfc-watchdog-commands-on-sonic)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sections can be omitted. Please move all this to a general readme under the pfcwd folder since it is the same for all cases

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted the TOC from the readme.


## Experiment Steps

1. Execute the test “PFCWD_Basic_All-to-all” test for only one priority (e.g., 3)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what the test "pfcwd basic all to all" does. Without that info, it is unclear what is being covered

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test ( pfcwd basic all to all test ) is part of PR ( #2205 ) - Test Plan : PFC Watchdog test plan and Test Case : 1.3.2 Test Case #2 - PFCWD all to all multi-host lossless traffic. Overall once this is coded , this will also be added in test plan document : #2205

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link to the testcase in this document

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PFC WD Test Plan is yet to merge in sonic-mgmt/master - is it ok to provide the link of PR ( #2205 ) in actual document.

Comment on lines +3 to +8
- [Background](#background)
- [PFC storm detection](#pfc-storm-detection)
- [PFC storm mitigation](#pfc-storm-mitigation)
- [PFC storm restoration](#pfc-storm-restoration)
- [PFC watchdog implementation](#pfc-watchdog-implementation)
- [PFC watchdog commands on SONiC](#pfc-watchdog-commands-on-sonic)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move these sections to a general readme

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitted the TOC section from readme

<code>$sudo warm-reboot [options] </code>

2. Wait for the DUT to come up
3. Execute the test &quot;PFCWD\_Basic\_All-to-all&quot; test for only one priority (e.g., 3)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain what is the pfcwd basic all to all test

Copy link
Copy Markdown
Contributor Author

@SubhajitPalKeysight SubhajitPalKeysight Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test ( pfcwd basic all to all test ) is part of PR ( #2205 ) - Test Plan : PFC Watchdog test plan and Test Case : 1.3.2 Test Case #2 - PFCWD all to all multi-host lossless traffic. Overall once this is coded , this will also be added in test plan document : #2205

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link to the testcase in this document

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PFC WD Test Plan is yet to merge in sonic-mgmt/master - is it ok to provide the link of PR ( #2205 ) in actual document ?

@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Mar 8, 2022

@neethajohn did author addressed all your questions?

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…submodule head (sonic-net#11705)

Kernel:
* 86c4b66 2022-07-28 | [Mellanox] Add new kernel patches from HW-MGMT package V.7.0020.3005 (sonic-net#287) (HEAD -> 202205) [Kebo Liu]
* 3a8416a 2022-07-05 | [patch] mlxsw: i2c: Prevent transaction execution for special chip (sonic-net#279) [Stepan Blyshchak]

swss:
* 3f69944 2022-08-10 | Set internal class state to reflect the actual state (sonic-net#2410) (HEAD -> 202205, tag: foo) [Prince Sunny]
* 87e98eb 2022-08-09 | [portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (sonic-net#2400) [Stephen Sun]
* e71ab99 2022-07-29 | portsorch: initial support for link-training (sonic-net#2359) [Dante (Kuo-Jung) Su]
* ed5e5be 2022-07-08 | Port configuration incremental update support (sonic-net#2305) [Junchao-Mellanox]

utilities:
* 0df3ba8 2022-08-12 | Revert "Improve the way to check port type of RJ45 port (sonic-net#2249)" (HEAD -> 202205) [Ying Xie]
* 9b21903 2022-08-12 | Fix test failure in dump table test in 202205 (sonic-net#2307) (HEAD -> 202205, github/202205) [Stephen Sun]
* 750d1db 2022-08-11 | Convert IPv6 addresses to lowercase in apply-patch (sonic-net#2299) (HEAD -> 202205) [dbarashinvd]
* 555947e 2022-08-09 | [config][muxcable] add support to enable/disable ycable telemetry (sonic-net#2297) [vdahiya12]
* 978f416 2022-08-09 | Fix GCU bug when backend service modifying config (sonic-net#2295) [jingwenxie]
* 8fed381 2022-08-02 | [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB (sonic-net#2223) (github/202205) [Stephen Sun]
* a1a09e4 2022-07-29 | Improve the way to check port type of RJ45 port (sonic-net#2249) [Stephen Sun]
* 9bdbfb8 2022-05-19 | sonic-utils: initial support for link-training (sonic-net#2071) [Dante (Kuo-Jung) Su]
* c088ec4 2022-08-10 | Support to enable fips for the command sonic_installer (sonic-net#2154) (sonic-net#2303) [xumia]

platform-daemon:
* 767cfb6 2022-08-09 | [ycabled] add capability to enable/disable telemetry (sonic-net#279) (HEAD -> 202205) [vdahiya12]

linkmgrd:
* cf1ba2b 2022-08-12 | wait for handler to be completed (sonic-net#114) (HEAD -> 202205, github/202205) [Jing Zhang]
* e99026c 2022-08-11 | [lgtm]: add uuid-dev to lgtm prepare (sonic-net#112) (HEAD -> 202205) [Jing Zhang]
* bd1b7f0 2022-08-11 | Adjust `DbInterfaceRaceConditionCheck` to Wait Longer for Handlers to be executed (sonic-net#111) (HEAD -> 202205, github/202205) [Jing Zhang]
* e9dc6b2 2022-08-11 | Backoff mux probing for server down scenario (sonic-net#106) [Jing Zhang]
* 0d61171 2022-08-09 | Fix race condition caused by strand `wrap` method (sonic-net#104) [Jing Zhang]
* e9ede7d 2022-07-02 | Enforce switch after config mux to active (sonic-net#95) [Longxiang Lyu]
* 15dbc30 2022-06-30 | Add unittest to verify mux toggle active (sonic-net#94) [Longxiang Lyu]

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants