[BMC] Add bmc-dual-mgmt topology definition and device inventory#23195

Merged

StormLiangMS merged 2 commits intosonic-net:masterfrom

Blueve:dev/jika/bmc1

Mar 24, 2026

Collaborator

Blueve commented Mar 23, 2026

Description of PR

Summary:
Add the foundational testbed infrastructure for BMC dual-mgmt topology testing. This is the first step toward enabling SONiC BMC test support as described in the BMC High-Level Test Plan.

This PR introduces:

The bmc-dual-mgmt topology definition file
Example device inventory entries for BMC testbed modeling
Console link definitions for BMC-to-host and lab-to-BMC serial connections

Type of change

Testbed and Framework(new/improvement)

Back port request

Approach

What is the motivation for this PR?

The SONiC BMC test framework requires new topology definitions and testbed modeling to treat the BMC as a DUT. The bmc-dual-mgmt topology supports the scenario where the BMC and main CPU each have their own dedicated management port on the switch front panel.

How did you do it?

Topology file (ansible/vars/topo_bmc-dual-mgmt.yml): Defined a minimal topology with a single console interface (0.115200.0 - line 0, 115200 baud) representing the BMC-to-host UART link, and dut_type: NetworkBmc. No VMs, ASN, or BGP configuration is needed since the BMC has no ASIC or data-plane.
Device inventory (ansible/files/sonic_lab_devices.csv): Added example entries:
- switch01 - Host-side SONiC switch
- switch01-bmc - BMC as DUT (HwSku: bmc, Type: DevSonic)
- switch01-bmc-con - BMC acting as console server for the host (HwSku: bmc, Type: ConsoleServer)
Console links (ansible/files/sonic_lab_console_links.csv): Added:
- console-1 -> switch01-bmc - Physical lab console to BMC (9600 baud)
- switch01-bmc-con -> switch01 - BMC to host via board-embedded UART (115200 baud)

How did you verify/test it?

Verified topology YAML structure matches the format used by existing topologies (e.g., topo_c0.yml)
Verified CSV entries follow the existing column format in sonic_lab_devices.csv and sonic_lab_console_links.csv

Any platform specific information?

This applies to platforms with a BMC running SONiC OS that have dual dedicated management ports (one for BMC, one for CPU).

Supported testbed topology if it is a new test case?

N/A - this PR adds testbed infrastructure only (topology definition + device inventory). Test cases will be added in follow-up PRs.

Documentation

Aligns with the BMC High-Level Test Plan, Section 3.1 (bmc-dual-mgmt).

Collaborator

mssonicbld commented Mar 23, 2026

/azp run

github-actions bot requested review from lizhijianrd, r12f and sdszhang

March 23, 2026 05:45

azure-pipelines bot commented Mar 23, 2026

Azure Pipelines successfully started running 1 pipeline(s).


          Add bmc-dual-mgmt topology and device inventory entries

65958ec

- Create topo_bmc-dual-mgmt.yml with console interface 0.115200.0
  and dut_type NetworkBmc (no VMs/BGP needed)
- Add BMC device entries to sonic_lab_devices.csv:
  switch01 (host), switch01-bmc (DUT), switch01-bmc-con (console server)
- Add console link entries to sonic_lab_console_links.csv:
  lab console -> BMC (9600), BMC -> host UART (115200)

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

Blueve force-pushed the dev/jika/bmc1 branch from cfef4f7 to 65958ec Compare

March 23, 2026 05:49

Collaborator

mssonicbld commented Mar 23, 2026

/azp run

azure-pipelines bot commented Mar 23, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

mssonicbld commented Mar 23, 2026

/azp run

github-actions bot requested a review from wangxin

March 23, 2026 06:02

azure-pipelines bot commented Mar 23, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Blueve force-pushed the dev/jika/bmc1 branch from f0fa90c to 0d4845c Compare

March 23, 2026 06:10

Collaborator

mssonicbld commented Mar 23, 2026

/azp run

azure-pipelines bot commented Mar 23, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Blueve marked this pull request as ready for review

March 23, 2026 06:12

yxieca previously approved these changes

View reviewed changes

Collaborator

yxieca commented Mar 23, 2026

/azp run

azure-pipelines bot commented Mar 23, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI mentioned this pull request

Review: human-authored PRs opened in past 48 hours (24 PRs) #23231

Draft

Blueve dismissed yxieca’s stale review via

7ec121a

March 24, 2026 02:21

Blueve force-pushed the dev/jika/bmc1 branch from 0d4845c to 7ec121a Compare

March 24, 2026 02:21

Collaborator

mssonicbld commented Mar 24, 2026

/azp run

azure-pipelines bot commented Mar 24, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Blueve force-pushed the dev/jika/bmc1 branch from 7ec121a to 29c712a Compare

March 24, 2026 02:23

Collaborator

mssonicbld commented Mar 24, 2026

/azp run

azure-pipelines bot commented Mar 24, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Blueve force-pushed the dev/jika/bmc1 branch from 29c712a to 30cb312 Compare

March 24, 2026 02:31

Collaborator

mssonicbld commented Mar 24, 2026

/azp run

azure-pipelines bot commented Mar 24, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Blueve force-pushed the dev/jika/bmc1 branch from 30cb312 to 52cf3bd Compare

March 24, 2026 02:40

Collaborator

mssonicbld commented Mar 24, 2026

/azp run

azure-pipelines bot commented Mar 24, 2026

Azure Pipelines successfully started running 1 pipeline(s).


          Add bmc topology type to testbed type regex

f26ffad

- Add 'bmc' to get_testbed_type() regex in tests/common/testbed.py
  so topology names like 'bmc-dual-mgmt' are recognized as type 'bmc'
  (same pattern as m1-48/m1-128 being recognized as type 'm1')

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

Blueve force-pushed the dev/jika/bmc1 branch from 52cf3bd to f26ffad Compare

March 24, 2026 02:52

Collaborator

mssonicbld commented Mar 24, 2026

/azp run

azure-pipelines bot commented Mar 24, 2026

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS approved these changes

View reviewed changes

Collaborator

StormLiangMS left a comment

LGTM

StormLiangMS merged commit f5e0940 into sonic-net:master

18 checks passed

Blueve commented

View reviewed changes

ansible/scripts/meta/validators/ip_address_validator.py

+                      Returns:
+                          bool: True if one is a BMC device and the other is its console server role
+                      """
+                      if device1_name + "-con" == device2_name:

Collaborator Author

Blueve Mar 24, 2026

this is the most simple approach to by-pass this validator.
i am thinking if we can do this by checking the testbed.yml and relax the validator if the device is a bmc

this will be a TODO

Blueve commented

View reviewed changes

ansible/scripts/meta/validators/pdu_validator.py

+                  @staticmethod
+                  def _is_bmc_host_pair(device1, device2):
+                      """Check if two devices are a BMC and its host sharing the same chassis."""
+                      if device1 + "-bmc" == device2:

Collaborator Author

Blueve Mar 24, 2026

This information can definitely get from the testbed.yml
Then we don't rely on hard coded naming convention

note a TODO here

Blueve mentioned this pull request

[BMC] Improve BMC validators to use testbed.yaml instead of naming convention #23263

Merged

1 task

ravaliyel pushed a commit to ravaliyel/sonic-mgmt that referenced this pull request


          [BMC] Add bmc-dual-mgmt topology definition and device inventory (son…

e31af8c

…ic-net#23195)

* Add bmc-dual-mgmt topology and device inventory entries

- Create topo_bmc-dual-mgmt.yml with console interface 0.115200.0
  and dut_type NetworkBmc (no VMs/BGP needed)
- Add BMC device entries to sonic_lab_devices.csv:
  switch01 (host), switch01-bmc (DUT), switch01-bmc-con (console server)
- Add console link entries to sonic_lab_console_links.csv:
  lab console -> BMC (9600), BMC -> host UART (115200)

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

* Add bmc topology type to testbed type regex

- Add 'bmc' to get_testbed_type() regex in tests/common/testbed.py
  so topology names like 'bmc-dual-mgmt' are recognized as type 'bmc'
  (same pattern as m1-48/m1-128 being recognized as type 'm1')

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

---------

Signed-off-by: Jing Kan <[email protected]>
Co-authored-by: Copilot <[email protected]>

Blueve mentioned this pull request

[BMC] Add LLDP management interface tests #23471

Open

12 tasks

selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request


          [BMC] Add bmc-dual-mgmt topology definition and device inventory (son…

6b5a68d

…ic-net#23195)

* Add bmc-dual-mgmt topology and device inventory entries

- Create topo_bmc-dual-mgmt.yml with console interface 0.115200.0
  and dut_type NetworkBmc (no VMs/BGP needed)
- Add BMC device entries to sonic_lab_devices.csv:
  switch01 (host), switch01-bmc (DUT), switch01-bmc-con (console server)
- Add console link entries to sonic_lab_console_links.csv:
  lab console -> BMC (9600), BMC -> host UART (115200)

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

* Add bmc topology type to testbed type regex

- Add 'bmc' to get_testbed_type() regex in tests/common/testbed.py
  so topology names like 'bmc-dual-mgmt' are recognized as type 'bmc'
  (same pattern as m1-48/m1-128 being recognized as type 'm1')

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

---------

Signed-off-by: Jing Kan <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: selldinesh <[email protected]>

albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request


          [BMC] Add bmc-dual-mgmt topology definition and device inventory (son…

1908c6f

…ic-net#23195)

* Add bmc-dual-mgmt topology and device inventory entries

- Create topo_bmc-dual-mgmt.yml with console interface 0.115200.0
  and dut_type NetworkBmc (no VMs/BGP needed)
- Add BMC device entries to sonic_lab_devices.csv:
  switch01 (host), switch01-bmc (DUT), switch01-bmc-con (console server)
- Add console link entries to sonic_lab_console_links.csv:
  lab console -> BMC (9600), BMC -> host UART (115200)

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

* Add bmc topology type to testbed type regex

- Add 'bmc' to get_testbed_type() regex in tests/common/testbed.py
  so topology names like 'bmc-dual-mgmt' are recognized as type 'bmc'
  (same pattern as m1-48/m1-128 being recognized as type 'm1')

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

---------

Signed-off-by: Jing Kan <[email protected]>
Co-authored-by: Copilot <[email protected]>

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request


          [BMC] Add bmc-dual-mgmt topology definition and device inventory (son…

06d752c

…ic-net#23195)

* Add bmc-dual-mgmt topology and device inventory entries

- Create topo_bmc-dual-mgmt.yml with console interface 0.115200.0
  and dut_type NetworkBmc (no VMs/BGP needed)
- Add BMC device entries to sonic_lab_devices.csv:
  switch01 (host), switch01-bmc (DUT), switch01-bmc-con (console server)
- Add console link entries to sonic_lab_console_links.csv:
  lab console -> BMC (9600), BMC -> host UART (115200)

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

* Add bmc topology type to testbed type regex

- Add 'bmc' to get_testbed_type() regex in tests/common/testbed.py
  so topology names like 'bmc-dual-mgmt' are recognized as type 'bmc'
  (same pattern as m1-48/m1-128 being recognized as type 'm1')

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jing Kan <[email protected]>

---------

Signed-off-by: Jing Kan <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: opcoder0 <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StormLiangMS StormLiangMS approved these changes

yxieca yxieca left review comments

lizhijianrd Awaiting requested review from lizhijianrd

r12f Awaiting requested review from r12f

sdszhang Awaiting requested review from sdszhang

wangxin Awaiting requested review from wangxin

Labels

None yet