Skip to content

[test_warm_reboot_multi_sad_inboot] Fix error in get_bgp_route_cnt#2316

Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms:fix_get_bgp_route
Oct 10, 2020
Merged

[test_warm_reboot_multi_sad_inboot] Fix error in get_bgp_route_cnt#2316
bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms:fix_get_bgp_route

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented Oct 9, 2020 •
edited
Loading

Description of PR

Summary:
This PR is to fix test case test_warm_reboot_multi_sad_inboot.
The output of show ip bgp summary has a line with only ---

Neighbhor      V          AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down      State/PfxRcd  NeighborName
-----------  ---  ----------  ---------  ---------  --------  -----  ------  ---------  --------------  --------------
10.0.0.33      4  4200064600       3210       4523         0      0       0  00:05:47             6400  ARISTA01T1
10.0.0.35      4  4200064600       3210       4523         0      0       0  00:05:47             6400  ARISTA02T1
10.0.0.37      4  4200064600       3210       4523         0      0       0  00:05:47             6400  ARISTA03T1
10.0.0.39      4  4200064600       3210       4523         0      0       0  00:05:47             6400  ARISTA04T1

However, the method get_bgp_route_cnt in sad_path.py failed to filter it out.
This commit address the issue.
Besides, this PR cancel the wait for last reboot operation, which will save 420 seconds.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

This PR is to fix test case test_warm_reboot_multi_sad_inboot.

How did you do it?

Update the script used to parse the output of show ip bgp sum.

How did you verify/test it?

Verified on Arista-7260.

py.test --inventory ../ansible/str,../ansible/veos --host-pattern str-7260cx3-acs-2 --module-path ../ansible --testbed vms7-t0-7260-2 --testbed_file ../ansible/testbed.csv --junit-xml=tr.xml --log-cli-level warn --collect_techsupport=False --topology=t0,any,util platform_tests/test_advanced_reboot.py::test_warm_reboot_multi_sad_inboot
========================================================================================= test session starts =========================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.5, py-1.9.0, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
metadata: {'Python': '2.7.12', 'Platform': 'Linux-4.10.0-42-generic-x86_64-with-Ubuntu-16.04-xenial', 'Packages': {'py': '1.9.0', 'pytest': '4.6.5', 'pluggy': '0.13.1'}, 'Plugins': {u'repeat': u'0.8.0', u'html': u'1.22.1', u'xdist': u'1.28.0', u'ansible': u'2.2.2', u'forked': u'1.3.0', u'metadata': u'1.10.0'}}
ansible: 2.8.12
rootdir: /data/Networking-acs-sonic-mgmt/tests, inifile: pytest.ini
plugins: ansible-2.2.2, forked-1.3.0, xdist-1.28.0, html-1.22.1, repeat-0.8.0, metadata-1.10.0
collected 1 item                                                                                                                                                                                      

platform_tests/test_advanced_reboot.py::test_warm_reboot_multi_sad_inboot ^@^@^@^@PASSED                                                                                                                [100%]

------------------------------------------------------------------ generated xml file: /data/Networking-acs-sonic-mgmt/tests/tr.xml -------------------------------------------------------------------
===================================================================================== 1 passed in 1381.94 seconds =====================================================================================
bingwang@df9bc4cdf9b3:/data/Networking-acs-sonic-mgmt$

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

No.

@bingwang-ms
Fix error in get_bgp_route_cnt
8e45af8 
The output of 'show ip bgp summary' has a line with only ---,
and the method get_bgp_route_cnt method in sad_path.py failed to filter it out.
This commit address the issue.
@bingwang-ms
Cancel unnecessary sleep for last reboot operation
b75c923
@bingwang-ms bingwang-ms requested review from neethajohn and tahmed-dev and removed request for neethajohn October 9, 2020 08:40
@bingwang-ms bingwang-ms merged commit 7b12d8f into sonic-net:master Oct 10, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@dprital
[202205][submodule] Advance sonic-swss pointer (sonic-net#11940)
1521690 
Update sonic-swss submodule pointer to include the following:

[BFD]Clean up state_db BFD entries on swss restart (sonic-net#2434)
Fix the Fec Mode Setting of gbsyncd (sonic-net#2430)
[neighsyncd] Enabling ipv4 link local entries for non-dualtor (sonic-net#2427)
tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE (sonic-net#2408)
PFCWD recovery changes using DLR_INIT (sonic-net#2316)
Dynamic port configuration - add port buffer cfg to the port ref counter (sonic-net#2194)

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neethajohn neethajohn neethajohn approved these changes

@tahmed-dev tahmed-dev Awaiting requested review from tahmed-dev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bingwang-ms @neethajohn