Skip to content

[Platform API][Fan] Compare applicable data against values from platform.json#2219

Merged
jleveque merged 12 commits intosonic-net:masterfrom
vdahiya12:enhance_fan_tests
Sep 26, 2020
Merged

[Platform API][Fan] Compare applicable data against values from platform.json#2219
jleveque merged 12 commits intosonic-net:masterfrom
vdahiya12:enhance_fan_tests

Conversation

@vdahiya12
Copy link
Copy Markdown
Contributor

@vdahiya12 vdahiya12 commented Sep 15, 2020

Summary:

For fan tests where known truths are available in the platform.json file, compare actual values against those truths

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

To improve the quality of the Fan platform API test

How did you do it?

For fan tests where known truths are available in the platform.json file, compare actual values against those truths

How did you verify/test it?

Run Fan tests on a device with a populated platform.json present

Any platform specific information?

Platform must have a populated platform.json present

Signed-off-by: vaibhav-dahiya [email protected]

@vdahiya12
[Platform API][Fan] enhance platform_api fan tests
3c5cef0 
Summary:

For fan tests where known truths are available in the platform.json file, compare actual values against those truths

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Approach
What is the motivation for this PR?
To improve the quality of the Fan platform API test

How did you do it?
For fan tests where known truths are available in the platform.json file, compare actual values against those truths

How did you verify/test it?
Run Fan tests on a device with a populated platform.json present

Any platform specific information?
Platform must have a populated platform.json present

Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
jleveque suggested changes Sep 15, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 15, 2020

This pull request fixes 1 alert when merging 3c5cef0 into 4ad939b - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 16, 2020

This pull request fixes 1 alert when merging 22eed57 into e01b6be - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

jleveque
jleveque suggested changes Sep 16, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
Comment thread tests/platform_tests/api/test_fan.py Outdated
Comment thread tests/platform_tests/api/test_fan.py Outdated
@vdahiya12
[pytest] fix the list access
21cc28f 
Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12
[pytest] fixing the comments
815f305 
Signed-off-by: vaibhav-dahiya <[email protected]>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 16, 2020

This pull request fixes 1 alert when merging 815f305 into e01b6be - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

jleveque
jleveque suggested changes Sep 19, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
jleveque
jleveque suggested changes Sep 23, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
Comment thread tests/platform_tests/api/test_fan.py Outdated
jleveque
jleveque suggested changes Sep 23, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
Comment thread tests/platform_tests/api/test_fan.py Outdated
@vdahiya12
[pytest] fixing the comments
d1031da 
Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12
[pytest] minor typo fixes
462f6d0 
Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12
[pytest] fixing the indexing
0b89589 
Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12
[pytest] readd the fixtures
d0ff321 
Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12
[pytest] typo
14b16e5 
Signed-off-by: vaibhav-dahiya <[email protected]>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 23, 2020

This pull request fixes 1 alert when merging 14b16e5 into 412cd01 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

jleveque
jleveque suggested changes Sep 23, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 23, 2020

This pull request fixes 1 alert when merging 37d2907 into 412cd01 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@vdahiya12
Copy link
Copy Markdown
Contributor Author

vdahiya12 commented Sep 23, 2020

Retest vsimage please

jleveque
jleveque suggested changes Sep 24, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
jleveque
jleveque suggested changes Sep 24, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
jleveque
jleveque suggested changes Sep 24, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py
@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Sep 24, 2020

Eventually, we will need to restructure these tests so as to handle modular chassis. Since fans can be contained in a number of other device types, I think it makes for the container device to run the fan tests on all fans contained within it. Until we refactor the tests to achieve this, however, I believe this fan test should test not only the fans directly on the chassis, but also in fan drawers and PSUs, rather than duplicating this code in the fan drawer and PSU tests. @vdahiya12: What do you think?

jleveque
jleveque suggested changes Sep 25, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
Comment thread tests/platform_tests/api/test_fan.py Outdated
@vdahiya12
[pytest] fix the comments
5ce12cb 
Signed-off-by: vaibhav-dahiya <[email protected]>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 25, 2020

This pull request fixes 1 alert when merging 5ce12cb into 30180c9 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Sep 25, 2020

Retest this please

jleveque
jleveque suggested changes Sep 25, 2020
View reviewed changes
Comment thread tests/platform_tests/api/test_fan.py Outdated
@vdahiya12
Copy link
Copy Markdown
Contributor Author

vdahiya12 commented Sep 25, 2020

Retest this please

@vdahiya12
[pytest] fixing the comments
c8683ff 
Signed-off-by: vaibhav-dahiya <[email protected]>
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Sep 25, 2020

This pull request fixes 1 alert when merging c8683ff into 5978ad2 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@jleveque jleveque merged commit 3c71b43 into sonic-net:master Sep 26, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@yxieca
[202205][swss][utilities][sairedis][pmon] advance submodule head (son…
f6f87f1 
…ic-net#11223)

swss:
* 43b9f06 2022-06-23 | [ACL] Support stage particular match fields (sonic-net#2341) (HEAD -> 202205) [bingwang-ms]
* c7f1add 2022-06-22 | Fix qos map test in vs test (sonic-net#2343) [bingwang-ms]
* 0549f3c 2022-06-22 | Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332) [anilkpan]

utilities:
* 785508d 2022-05-25 | [GCU] Handling type1 lists (sonic-net#2171) (HEAD -> 202205) [Mohamed Ghoneim]
* 56c2c6b 2022-06-22 | [config reload] Fixing config reload when timer based services are disabled (sonic-net#2200) (sonic-net#2226) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* 600979e 2022-06-16 | Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219) [Dror Prital]

sairedis:
* 14fba45 2022-06-13 | [vslib]: Fixbug in cleanup MACsec device (sonic-net#1059) (HEAD -> 202205) [Ze Gan]
* ac6e7ad 2022-04-29 | [vslib]: Update packet number of MACsec SA at runtime (sonic-net#1007) [Ze Gan]

platform-daemons:
* 6ffec22 2022-06-22 | [ycabled] Fix the init values for active-active ports (sonic-net#266) (HEAD -> 202205) [vdahiya12]

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@judyjoseph
Update submodules
02d1783 
sonic-swss

25fe915 [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal (sonic-net#2327)
1c3c5e0 [BFD]Retry create BFD with different source UDP port on failure (sonic-net#2225)
d5775b1 Skip consistent fail tests (sonic-net#2269)

sonicutilities

5800b73 Fix header for the output table following 'show ipv6 interface' command (sonic-net#2219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sujinmkang sujinmkang Awaiting requested review from sujinmkang

@yxieca yxieca Awaiting requested review from yxieca

1 more reviewer

@jleveque jleveque jleveque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Enhancement Platform Pytest 🐍

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vdahiya12 @jleveque