Skip to content

[vnet-route-leak]: Add VNET route leak test#2163

Merged
yxieca merged 6 commits intosonic-net:masterfrom
theasianpianist:route-leak-test
Sep 14, 2020
Merged

[vnet-route-leak]: Add VNET route leak test#2163
yxieca merged 6 commits intosonic-net:masterfrom
theasianpianist:route-leak-test

Conversation

@theasianpianist
Copy link
Copy Markdown
Contributor

@theasianpianist theasianpianist commented Aug 31, 2020

Signed-off-by: Lawrence Lee [email protected]

Description of PR

Summary:
Add VNET route leak test

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Confirm that VNET routes are not leaked to BGP neighbors

How did you do it?

Add test module that programs VNET routes to DUT, then checks routes advertised to BGP neighbors

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

T0

Documentation

./run_tests.sh -n <testbed> -i <inventory> -u -c vxlan/test_vnet_route_leak.py

@theasianpianist theasianpianist requested review from a team and prsunny August 31, 2020 19:29
@theasianpianist theasianpianist marked this pull request as draft August 31, 2020 21:12
@prsunny
Copy link
Copy Markdown
Contributor

prsunny commented Aug 31, 2020

Please handle reload scenarios.

@theasianpianist theasianpianist marked this pull request as ready for review September 1, 2020 21:06
@theasianpianist
Copy link
Copy Markdown
Contributor Author

retest vsimage please

Copy link
Copy Markdown
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backup original config.

* Implicitly yield `None`
* Backup config_db and restore instead of using `config save`
* Add example regex match
* Use `defaultdict` to store leaked routes
* Use `pytest_assert` in place of `assert`
* Add clarifying comments

Signed-off-by: Lawrence Lee <[email protected]>
* Cleanup with `config reload` instead of manual cleanup

Signed-off-by: Lawrence Lee <[email protected]>
@isabelmsft isabelmsft requested a review from yxieca September 2, 2020 18:38
* Use `config reload` as fallback during test cleanup
* Make BGP session check more robust
* Refactor regex into function

Signed-off-by: Lawrence Lee <[email protected]>
@yxieca yxieca merged commit e433d31 into sonic-net:master Sep 14, 2020
@theasianpianist theasianpianist deleted the route-leak-test branch May 13, 2021 22:52
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…rm-common] advance submodule head (sonic-net#11578)

linkmgrd:
* e0fe1d4 2022-07-27 | TSA enhancement (sonic-net#98) (HEAD -> 202205) [Jing Zhang]

utilities:
* 7d7e15e 2022-07-18 | [vnet_route_check] Align DB data parse logic with format used by swsscommon API (sonic-net#2268) (HEAD -> 202205) [Volodymyr Samotiy]
* b3d5d18 2022-07-20 | [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (sonic-net#2258) [Marty Y. Lok]
* 504ebe6 2022-07-08 | Add 'traffic_shift_away' option to config load_minigraph (sonic-net#2240) [tjchadaga]
* 4079e4a 2022-06-20 | Gives cisco-8000 more flexibility to easily add subcommnads under show platform (sonic-net#2213) [Nathan Cohen]
* 46443c6 2022-07-27 | Update db_migrator to support `PORT_QOS_MAP|global` (sonic-net#2205) [bingwang-ms]
* d7fbdd6 2022-05-26 | fix for non-coherent cmis modules (sonic-net#2163) [qinchuanares]
* 79b4439 2022-06-24 | [sfpshow/sfputil] Enhance sfpshow and sfputil to behavior correctly on RJ45 ports (sonic-net#2111) [Kebo Liu]

swss:
* 275f311 2022-07-26 | [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2397) (HEAD -> 202205) [Devesh Pathak]
* 47586e8 2022-07-22 | [EVPN]Fix missing Vlan member update notification in P2MP scenario (sonic-net#2388) [Sudharsan Dhamal Gopalarathnam]
* 7d5c73f 2022-07-19 | [macsecmgr]: Fix cleanup macsec objs if container stop (sonic-net#2376) [Ze Gan]
* c03996f 2022-07-17 | [orchagent]: Enhance initSaiPhyApi (sonic-net#2367) [andywongarista]
* 57890d7 2022-07-27 | Fix for remote system interface not getting created (sonic-net#2364) [skeesara-nokia]
* 1a93ec9 2022-07-13 | Orchagent changes for synchronizing npu/phy device Tx in the data path before enabling transceiver<CMIS compliant> Tx. (sonic-net#2277) [jaganbal-a]

sairedis:
* a4903be 2022-07-20 | Update PN with XPN support (sonic-net#1081) (HEAD -> 202205, github/202205) [Ze Gan]
* 2cb5671 2022-07-27 | Add SAI_OBJECT_TYPE_TUNNEL object to break-before-make list (sonic-net#1075) [Vaibhav Hemant Dixit]

platform-daemon:
* 901c6a1 2022-06-28 | [CMIS]Improved 400G link bring up sequence (sonic-net#254) (HEAD -> 202205) [Prince George]

platform-common:
* f223b3f 2022-07-09 | Support get_port_or_cage_type (sonic-net#288) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants