Skip to content

[Snappi] Adding convergence check function with tolerance#21565

Open
selldinesh wants to merge 11 commits intosonic-net:masterfrom
selldinesh:pr_reboot_rate
Open

[Snappi] Adding convergence check function with tolerance#21565
selldinesh wants to merge 11 commits intosonic-net:masterfrom
selldinesh:pr_reboot_rate

Conversation

@selldinesh
Copy link
Copy Markdown
Contributor

@selldinesh selldinesh commented Dec 4, 2025

Description of PR

Summary: This PR contains the fixture that checks if the traffic has converged or not by comparing the tx and rx frame rate with the tolerance provided.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Instead of having convergence check code for each testcase added a common fixture

How did you do it?

Test on BGP convergence testcases

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

t0/t1

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Copy Markdown
Contributor

sdszhang commented Dec 4, 2025

@selldinesh can you update the PR description?

Comment thread tests/common/snappi_tests/snappi_helpers.py
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts:
#	tests/common/snappi_tests/snappi_helpers.py

Signed-off-by: selldinesh <[email protected]>
Signed-off-by: selldinesh <[email protected]>
Signed-off-by: selldinesh <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Mar 26, 2026

/azp run

@selldinesh
Copy link
Copy Markdown
Contributor Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

Build not found. Please close and reopen the PR or rebase your branch to trigger a new build.

@r12f
Copy link
Copy Markdown
Collaborator

r12f commented Mar 26, 2026

/azpw retry

@mssonicbld
Copy link
Copy Markdown
Collaborator

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

No Azure DevOps builds found for #21565.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

1 similar comment
@yijingyan2
Copy link
Copy Markdown

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@selldinesh
Copy link
Copy Markdown
Contributor Author

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

The following failed(or canceled) jobs were not retried:

  • kvmtest-t1-lag-vpp by Elastictest [OPTIONAL]

Job kvmtest-t1-lag-vpp by Elastictest [OPTIONAL] is an optional job and does not block the PR merge, so it will not be retried.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants