Fix bgp_bbr and fib::nvgre_hash related conditions#20956
Merged
StormLiangMS merged 4 commits intosonic-net:masterfrom Nov 6, 2025
Merged
Fix bgp_bbr and fib::nvgre_hash related conditions#20956StormLiangMS merged 4 commits intosonic-net:masterfrom
StormLiangMS merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
reviewed
Oct 21, 2025
tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
hi @yejianquan would you help to take this to 202505? |
Collaborator
|
@justin-wong-ce would you help to manual submit to 202503? |
Merged
13 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#815 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Nov 12, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific
MaxXiao12
added
Approved for 202505 branch
and removed
Request for 202505 branch
labels
Collaborator
|
@justin-wong-ce PR conflicts with 202505 branch |
StormLiangMS
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Nov 13, 2025
Cherry picking sonic-net/sonic-mgmt#20956 to Azure/sonic-mgmt.msft 202503 branch Doing this by mirroring the skip conditions from the above PR to the `fib/test_fib.py::test_nvgre_hash` conditions in 202503 - which is only 1 entry compared to other branches.
11 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 27, 2025
vikumarks
pushed a commit
to vikumarks/sonic-mgmt
that referenced
this pull request
Dec 1, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: vikumarks <[email protected]>
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Dec 2, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Alberto Villarreal <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: opcoder0 <[email protected]>
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Dec 9, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Nishanth Sampath Kumar <[email protected]>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: selldinesh <[email protected]>
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Dec 12, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Saravanan <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: YiFan Wang <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Guy Shemesh <[email protected]>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: Raghavendran Ramanathan <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…utomatically (sonic-net#20956) #### Why I did it src/sonic-host-services ``` * 113a5c4 - (HEAD -> 202311, origin/202311) [caclmgrd][DualToR] Fix a case where vlan address is not network address for DualToR Active-active configuration (sonic-net#95) (4 hours ago) [vdahiya12] ``` #### How I did it #### How to verify it #### Description for the changelog
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Apr 1, 2026
What is the motivation for this PR? Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix. How did you do it? Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order. How did you verify/test it? fib/test_fib.py::test_nvgre_hash is skipped properly on Broadcom platforms after the fix. Any platform specific information? Broadcom specific Signed-off-by: selldinesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
ipv6 topo-only skips are recently introduced to various test cases. Within those cases are various sub-cases of
fib/test_fib.py::test_nvgre_hash.New skip entries are added for the specific sub-cases, which overrides the umbrella skip condition for fib/test_fib.py::test_nvgre_hash, causing the cases to be unintentionally unskipped.
Fix by adding the needed skip conditions to the sub-case entries.
Also fixing some entries that were not in alphabetical order.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Tests are unintentionally unskipped, and there are commit checks that failed when attempting to commit the fix.
How did you do it?
Added the missing skip conditions and rearranged the order of skip conditions to match the alphabetical order.
How did you verify/test it?
fib/test_fib.py::test_nvgre_hashis skipped properly on Broadcom platforms after the fix.Any platform specific information?
Broadcom specific
Supported testbed topology if it's a new test case?
Documentation