Skip to content

[202411] Disable Cisco VOQ WD for dualtor QOS, improve PG test debuggability#20870

Merged
StormLiangMS merged 1 commit intosonic-net:202411from
rbpittman:disable_voq_wd_tunnel_tests_202411_take3
Oct 23, 2025
Merged

[202411] Disable Cisco VOQ WD for dualtor QOS, improve PG test debuggability#20870
StormLiangMS merged 1 commit intosonic-net:202411from
rbpittman:disable_voq_wd_tunnel_tests_202411_take3

Conversation

@rbpittman
Copy link
Copy Markdown
Contributor

@rbpittman rbpittman commented Sep 30, 2025

Description of PR

Summary:
Double commit #20502

  • Disable VOQ WD during test_tunnel_qos_remap.py
  • Commonize some aspects of the VOQ WD disabling from QOS SAI to avoid major code duplication.
  • Improve performance of test for cisco by reducing unnecessary 8-second per loop wait time to 1 second. (Test passed with 0.5 seconds as well, since this is a SAI bypass operation the updated stat should be near-instant).
  • Improve debuggability of PG tunnel decap test by logging all failures and summarizing a report at the end.
  • Fix up test_voq_watchdog.py test with new commonization. Rename parametrization to avoid shadowing.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

No validation.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@rbpittman
Disable Cisco VOQ WD for dualtor QOS, improve PG test debuggability (s…
7a64e98 
…onic-net#20502)

* Disable Cisco VOQ watchdog for dualtor tunnel tests. Improve debuggability and speed of the tunnel PG map test.

* Fix VOQ watchdog test.
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Sep 30, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 30, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@rbpittman rbpittman mentioned this pull request Sep 30, 2025
Merged
14 tasks
@rbpittman
Copy link
Copy Markdown
Contributor Author

rbpittman commented Oct 1, 2025

BGP and pretest random failures

@rbpittman
Copy link
Copy Markdown
Contributor Author

rbpittman commented Oct 1, 2025

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Oct 1, 2025

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Oct 1, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@StormLiangMS StormLiangMS requested a review from yyynini October 15, 2025 06:24
yyynini
yyynini approved these changes Oct 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@yyynini yyynini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolyu lolyu self-requested a review October 20, 2025 06:38
XuChen-MSFT
XuChen-MSFT approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@XuChen-MSFT XuChen-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

StormLiangMS
StormLiangMS approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 58b8b03 into sonic-net:202411 Oct 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StormLiangMS StormLiangMS StormLiangMS approved these changes

@XuChen-MSFT XuChen-MSFT XuChen-MSFT approved these changes

@yyynini yyynini yyynini approved these changes

@lolyu lolyu Awaiting requested review from lolyu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rbpittman @mssonicbld @StormLiangMS @XuChen-MSFT @yyynini