[test_dynamic_acl] Include all upstream neighbors for t0-d18u8s4#18901
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Jun 16, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
Jun 10, 2025
Signed-off-by: zitingguo-ms <[email protected]>
Gfrom2016
force-pushed
the
fix_dynamic_acl_with_service_port
branch
from
5cc676f to
de62374
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@Gfrom2016 PR conflicts with 202411 branch |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 17, 2025
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100
Collaborator
|
Cherry-pick PR to 202505: #19036 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 17, 2025
) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
5 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Jun 24, 2025
) Summary: Fixes # (issue) This is a manual cherry-pick of #18901
Gfrom2016
added
Included in 202411 branch
and removed
Cherry Pick Conflict_202411
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100 Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100 Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100 Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100 Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100 Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100 Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…ic-net#18901) What is the motivation for this PR? To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors. How did you do it? Use get_all_upstream_neigh_type instead of get_upstream_neigh_type in setup. How did you verify/test it? Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed. generic_config_updater/test_dynamic_acl.py::test_gcu_acl_drop_rule_removal[default-Vlan1000] PASSED [100%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str4-7050cx3-c28s4-1-None-default-Vlan1000] PASSED [ 50%] generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV6-str4-7050cx3-c28s4-1-None-default-Vlan100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Fix generic_config_updater/test_dynamic_acl.py failure due to not including service ports in upstream neighbors.
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix the generic_config_updater/test_dynamic_acl.py failure by adding service ports in upstream neighbors.
How did you do it?
Use
get_all_upstream_neigh_typeinstead ofget_upstream_neigh_typeinsetup.How did you verify/test it?
Run test_dynamic_acl.py on topo t0-d18u8s4 and all passed.
Signed-off-by: zitingguo-ms [email protected]