[action] [PR:18213] Use is_alive over isAlive for py3 threads#18469
Merged
kperumalbfn merged 1 commit intosonic-net:202411from May 21, 2025
Merged
[action] [PR:18213] Use is_alive over isAlive for py3 threads#18469kperumalbfn merged 1 commit intosonic-net:202411from
kperumalbfn merged 1 commit intosonic-net:202411from
Conversation
What is the motivation for this PR? The python isAlive method for checking thread liveliness is for py2/earlier versions of py3. In py3.9 it is fully removed, and only is_alive is supported. Best to switch to is_alive for all versions of py3. How did you do it? How did you verify/test it? Tested on Arista testbed
11 tasks
Collaborator
Author
|
Original PR: #18213 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
May 30, 2025
) ``` 8b16a64 (HEAD -> sync/202503, origin/sync/202503) Merge remote-tracking branch 'az_upstream/202412' into sync/202503 fe0ac4a (az_upstream/202412) Merge branch '202411' of https://github.com/sonic-net/sonic-mgmt into 202412 5c0cad1 Use is_alive over isAlive for py3 threads (sonic-net#18213) (sonic-net#18469) b7f49b2 [action] [PR:16972] Update the sflow test to pass on the t0 topo which does not have portchannel (sonic-net#307) 64ecd5c Merge branch '202411' of https://github.com/sonic-net/sonic-mgmt into 202412 da50df8 Fix the generate_golden_config_db for multi-asic devices (sonic-net#18138) a52cceb [action] [PR:18444] support t1-isolated-d56u2 in test_acl.py, test_stress_acl.py and test_qos_sai (sonic-net#305) fa05606 fix bfd multihop test issue (sonic-net#18370) (sonic-net#18403) c1f8f0f [action] [PR:18289] Fix ACL tests for t1-isolated-d28/128 (sonic-net#304) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The python isAlive method for checking thread liveliness is for py2/earlier versions of py3. In py3.9 it is fully removed, and only is_alive is supported. Best to switch to is_alive for all versions of py3.
How did you do it?
How did you verify/test it?
Tested on Arista testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation