Skip to content

[DT2] Enhance test_acl to support FT2 topo#18464

Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms:enhance_acl_test_for_ft2
May 29, 2025
Merged

[DT2] Enhance test_acl to support FT2 topo#18464
bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms:enhance_acl_test_for_ft2

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented May 17, 2025

Description of PR

Summary:
This PR is to enhance test_acl to support FT2 topology.

Change list:

  1. Add FT2 to topology marker
  2. Add port selection for FT2
  3. Skip uplink->downlink test on FT2

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

This PR is to enhance test_acl to support FT2 topology.

How did you do it?

  1. Add FT2 to topology marker
  2. Add port selection for FT2
  3. Skip uplink->downlink test on FT2

How did you verify/test it?

The change is verified on a FT2 topo

acl/test_acl.py::TestBasicAcl::test_ingress_unmatched_blocked[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                     [ 75%]
acl/test_acl.py::TestBasicAcl::test_egress_unmatched_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] SKIPPED (Only run for egress)                                                                             [ 75%]
acl/test_acl.py::TestBasicAcl::test_source_ip_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                     [ 75%]
acl/test_acl.py::TestBasicAcl::test_rules_priority_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                      [ 75%]
acl/test_acl.py::TestBasicAcl::test_rules_priority_dropped[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                        [ 75%]
acl/test_acl.py::TestBasicAcl::test_dest_ip_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                       [ 75%]
acl/test_acl.py::TestBasicAcl::test_dest_ip_match_dropped[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                         [ 75%]
acl/test_acl.py::TestBasicAcl::test_source_ip_match_dropped[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                       [ 76%]
acl/test_acl.py::TestBasicAcl::test_udp_source_ip_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                 [ 76%]
acl/test_acl.py::TestBasicAcl::test_udp_source_ip_match_dropped[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                   [ 76%]
acl/test_acl.py::TestBasicAcl::test_icmp_source_ip_match_dropped[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                  [ 76%]
acl/test_acl.py::TestBasicAcl::test_icmp_source_ip_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                [ 76%]
acl/test_acl.py::TestBasicAcl::test_l4_dport_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                      [ 76%]
acl/test_acl.py::TestBasicAcl::test_l4_sport_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                      [ 76%]
acl/test_acl.py::TestBasicAcl::test_l4_dport_range_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                [ 76%]
acl/test_acl.py::TestBasicAcl::test_l4_sport_range_match_forwarded[ipv6-ingress-downlink->uplink-default-no_vlan] PASSED                                                                                                [ 77%]
acl/test_acl.py::TestBasicAcl::test_l4_dport_range_match_dropped[ipv6-ingress-downlink->uplink-default-no_vlan]  ^HPASSED                                                                                                  [ 77%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test.

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 17, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 27, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented May 27, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms changed the title Enhance test_acl to support FT2 topo [DT2] Enhance test_acl to support FT2 topo May 27, 2025
@bingwang-ms bingwang-ms merged commit 4438d3f into sonic-net:master May 29, 2025
18 checks passed
@bingwang-ms bingwang-ms mentioned this pull request May 29, 2025
Merged
bingwang-ms added a commit to Azure/sonic-mgmt.msft that referenced this pull request May 29, 2025
@bingwang-ms
[202503] Enhance test_acl to support FT2 topo (#18464) (#342)
cc7be47 
This PR is to cherry-pick
sonic-net/sonic-mgmt#18464 to 202503 branch
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request May 30, 2025
@bingwang-ms
Enhance test_acl to support FT2 topo (sonic-net#18464)
079cae3
bachalla pushed a commit to bachalla/sonic-mgmt that referenced this pull request Jun 2, 2025
@bingwang-ms @bachalla
Enhance test_acl to support FT2 topo (sonic-net#18464)
3684ad3
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@bingwang-ms
Enhance test_acl to support FT2 topo (sonic-net#18464)
602e7b3 
Signed-off-by: opcoder0 <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@bingwang-ms @AharonMalkin
Enhance test_acl to support FT2 topo (sonic-net#18464)
b8ee683 
Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@bingwang-ms @gshemesh2
Enhance test_acl to support FT2 topo (sonic-net#18464)
5bc1e4a 
Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@bingwang-ms @venu-nexthop
Enhance test_acl to support FT2 topo (sonic-net#18464)
7d93491
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@bingwang-ms @gshemesh2
Enhance test_acl to support FT2 topo (sonic-net#18464)
340b312 
Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@bingwang-ms
Enhance test_acl to support FT2 topo (sonic-net#18464)
fd0eb18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auspham auspham auspham approved these changes

Assignees

No one assigned

Labels

Approved for msft-202503 Branch Cherry Pick Conflict_msft-202503 Included in msft-202503 Branch Request for msft-202503 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bingwang-ms @mssonicbld @auspham