Skip to content

[pytest][neighbor-mac] Convert Neighbor MAC no PTF test case#1821

Merged
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/convert-neighbor-mac-noptf-test
Jul 1, 2020
Merged

[pytest][neighbor-mac] Convert Neighbor MAC no PTF test case#1821
tahmed-dev merged 2 commits intosonic-net:masterfrom
tahmed-dev:taahme/convert-neighbor-mac-noptf-test

Conversation

@tahmed-dev
Copy link
Copy Markdown
Contributor

@tahmed-dev tahmed-dev commented Jun 26, 2020

Description of PR

Summary:
This PR converts Ansible neighbor-mac-noptf test case to pytest framework.

signed-off-by: Tamer Ahmed [email protected]

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

Closing gap between Ansible and pytest framework

How did you do it?

Converted .yml test to Python pytest

How did you verify/test it?

tests$ pytest arp/test_neighbor_mac_noptf.py --testbed=vms12-t0-s6000-1 --inventory=../ansible/str --testbed_file=../ansible/testbed.csv --host-pattern=str-s6000-acs-14 --module-path=../ansible/library --disable_loganalyzer --skip_sanity
================================================================================================================================================== test session starts ==================================================================================================================================================
platform linux2 -- Python 2.7.12, pytest-4.6.9, py-1.8.1, pluggy-0.13.1
ansible: 2.8.7
rootdir: /var/host-acs-mgmt-repo/tests, inifile: pytest.ini
plugins: ansible-2.2.2
collected 2 items                                                                                                                                                                                                                                                                                                       

arp/test_neighbor_mac_noptf.py ..                                                                                                                                                                                                                                                                                 [100%]

============================================================================================================================================== 2 passed in 295.24 seconds ===============================================================================================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@tahmed-dev
[pytest][neighbor-mac] Conver Neighbor MAC no PTF test case
5fda492 
This PR converts ANsible neighbor-mac-noptf test case to pytest framweowrk.

signed-off-by: Tamer Ahmed <[email protected]>
@tahmed-dev tahmed-dev requested a review from a team June 26, 2020 17:12
wangxin
wangxin reviewed Jun 28, 2020
View reviewed changes
Comment thread tests/arp/test_neighbor_mac_noptf.py
from common.helpers.assertions import pytest_assert

logger = logging.getLogger(__name__)

Copy link
Copy Markdown
Collaborator

@wangxin wangxin Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add topology mark

pytestmark = [
    pytest.mark.topology('any')
]

Copy link
Copy Markdown
Contributor Author

@tahmed-dev tahmed-dev Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

yxieca
yxieca reviewed Jun 30, 2020
View reviewed changes
Comment thread tests/arp/test_neighbor_mac_noptf.py Outdated
yxieca
yxieca reviewed Jun 30, 2020
View reviewed changes
Comment thread tests/arp/test_neighbor_mac_noptf.py Outdated
@tahmed-dev tahmed-dev force-pushed the taahme/convert-neighbor-mac-noptf-test branch from 364c606 to 0e6608b Compare June 30, 2020 21:43
@tahmed-dev tahmed-dev requested review from wangxin and yxieca June 30, 2020 21:43
neethajohn
neethajohn reviewed Jun 30, 2020
View reviewed changes
Comment thread tests/arp/test_neighbor_mac_noptf.py
@tahmed-dev tahmed-dev requested a review from neethajohn July 1, 2020 00:53
@tahmed-dev tahmed-dev merged commit c572575 into sonic-net:master Jul 1, 2020
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@abdosi
[Submodule Update] sonic-utilities
501a233 
f81043b1f9ff02196629655f4735b33afd7f0ae1 (HEAD -> 202111, origin/202111) [port2alias]: Fix to get right number of return values (sonic-net#1906)
bbbf65943ec46e9330eadaed8bcdf1612cb8bd55 [CLI][show bgp] On chassis don't show internal BGP sessions by default (sonic-net#1927)
e12de7e7bf6cff3ec127f261bf88e4d29776d27b [port] Fix port speed set (sonic-net#1952)
cae7af752d484956d7fe40e4c3a849ddad460976 Fix invalid output of syslog IPv6 servers (sonic-net#1933)
6009341ddf790094166be5f0a81b4c114f00220b Routed subinterface enhancements (sonic-net#1821)
6ab9d67ca6550c592b97afb513804be474f84eb0 Enhance sfputil for CMIS QSFP (sonic-net#1949)
76cc67ba4f81c69b20efb3341808037c9db8f703 [debug dump] Refactoring Modules and Unit Tests (sonic-net#1943)
cff58a8171423e4012bc8caf9748996a1e98b7e2 Add command reference for trap flow counters (sonic-net#1876)
71cf3ee43524d56ad57dd90b937cfbf4bf63ba6a [Reclaim buffer] [Mellanox] Db migrator support reclaiming reserved buffer for unused ports (sonic-net#1822)
e699b49fb722e6d6fe5a1d2dacd2d39eb085c1e4 Add show command for BFD sessions (sonic-net#1942)
bb6c5774c843dbfad5f1ba00ee76dae7720902d1 [warm-reboot] Fix failures of warm reboot on disconnect of ssh session (sonic-net#1529)
2e8bbb308477862a76d2327fcf696875e8f08650 Add trap flow counter support (sonic-net#1868)
58407c1386ef13772a9a9320a795e380f162ab2c [load_minigraph] Delay pfcwd start until the buffer templates are rendered (sonic-net#1937)
eb388e0584ba1fe8d8dba58f1c5a148036ffe047 [sonic-package-manager] support sonic-cli-gen and packages with YANG model (sonic-net#1650)
2371d84e7d281bdb9988b5a1a012498dbbfb89ec generic_config_updater: Filename changed & VLAN validator added (sonic-net#1919)
7c0718dfaf23289d4ecc3ada9332e465c9a4e56b [config reload] Update command reference (sonic-net#1941)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

@neethajohn neethajohn neethajohn approved these changes

@wangxin wangxin Awaiting requested review from wangxin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tahmed-dev @wangxin @yxieca @neethajohn