Fix the generate_golden_config_db for multi-asic devices#17556
Merged
judyjoseph merged 1 commit intosonic-net:masterfrom Mar 22, 2025
Merged
Fix the generate_golden_config_db for multi-asic devices#17556judyjoseph merged 1 commit intosonic-net:masterfrom
judyjoseph merged 1 commit intosonic-net:masterfrom
Conversation
…ite of config for multi-asic devices
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
approved these changes
Mar 19, 2025
judyjoseph
approved these changes
Mar 20, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
hi @BYGX-wcr @FengPan-Frank could you help to run 202411 with this fix on both t2 and pizzabox to avoid regression? For cherrypick, we need to make sure it works with 202411 before cherry pick. |
Collaborator
|
@BYGX-wcr PR conflicts with 202411 branch |
Collaborator
|
Hi @BYGX-wcr , could you please help cherry-pick this one into 202411? |
Contributor
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
…ite of config for multi-asic devices (sonic-net#17556)
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
…ite of config for multi-asic devices (sonic-net#17556)
11 tasks
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ite of config for multi-asic devices (sonic-net#17556) Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ite of config for multi-asic devices (sonic-net#17556) Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ite of config for multi-asic devices (sonic-net#17556) Signed-off-by: Guy Shemesh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: The previous PR #17024 changed the image version checking for BMP feature and provided a new API for overwriting features config in golden_config_db.json. However, the implementation was problematic and broke the setup for multi-asic virtual chassis.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation