disable pfcwd before running qos_sai testing.#17393
Merged
yejianquan merged 4 commits intosonic-net:masterfrom Mar 12, 2025
Merged
disable pfcwd before running qos_sai testing.#17393yejianquan merged 4 commits intosonic-net:masterfrom
yejianquan merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yejianquan
previously approved these changes
Mar 7, 2025
Collaborator
yejianquan
left a comment
yejianquan
left a comment
There was a problem hiding this comment.
LGTM, waiting for the test to pass
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
commented
Mar 7, 2025
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # tests/qos/qos_sai_base.py
# Conflicts: # tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@sdszhang PR conflicts with 202411 branch |
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 12, 2025
Description of PR Summary: After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports. Approach What is the motivation for this PR? PFCWD needs to be disabled on backplane ports when running qos_sai testing How did you do it? added module level fixture to disable pfcwd co-authorized by: [email protected] (cherry picked from commit 69034ab)
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 12, 2025
Description of PR Summary: After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports. Approach What is the motivation for this PR? PFCWD needs to be disabled on backplane ports when running qos_sai testing How did you do it? added module level fixture to disable pfcwd co-authorized by: [email protected] (cherry picked from commit 69034ab)
yejianquan
pushed a commit
that referenced
this pull request
Mar 14, 2025
Description of PR Summary: After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports. Approach What is the motivation for this PR? PFCWD needs to be disabled on backplane ports when running qos_sai testing How did you do it? added module level fixture to disable pfcwd co-authorized by: [email protected] (cherry picked from commit 69034ab)
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports. Approach What is the motivation for this PR? PFCWD needs to be disabled on backplane ports when running qos_sai testing How did you do it? added module level fixture to disable pfcwd co-authorized by: [email protected]
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
Description of PR Summary: After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports. Approach What is the motivation for this PR? PFCWD needs to be disabled on backplane ports when running qos_sai testing How did you do it? added module level fixture to disable pfcwd co-authorized by: [email protected]
zhixzhu
pushed a commit
to zhixzhu/sonic-mgmt
that referenced
this pull request
May 1, 2025
[PR:17393][202405] disable pfcwd before running qos_sai testing. Cherry pick sonic-mgmt sonic-net#17393 Description of PR Summary: After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports. Approach What is the motivation for this PR? PFCWD needs to be disabled on backplane ports when running qos_sai testing How did you do it? added module level fixture to disable pfcwd co-authorized by: [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
After sonic-net/sonic-utilities#3792, we need to disable pfcwd on backplane ports.
Type of change
Back port request
Approach
What is the motivation for this PR?
PFCWD needs to be disabled on backplane ports when running qos_sai testing
How did you do it?
added module level fixture to disable pfcwd
How did you verify/test it?
TBD
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation