Skip to content

[GCU] Adding t2 support in gcu lo test case#17293

Merged
judyjoseph merged 4 commits intosonic-net:masterfrom
okaravasi:master-gcu_t2_support_lo_interface
Jul 21, 2025
Merged

[GCU] Adding t2 support in gcu lo test case#17293
judyjoseph merged 4 commits intosonic-net:masterfrom
okaravasi:master-gcu_t2_support_lo_interface

Conversation

@okaravasi
Copy link
Copy Markdown
Contributor

Description of PR

The original change was included in https://github.com/sonic-net/sonic-mgmt/pull/15236/files.
However, the code changes were handled in a different PR. This PR only adds support for T2.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • [ X] 202405
  • 202411

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Ran in kvm-t0, t2 chassis.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@okaravasi okaravasi changed the title Adding t2 support in gcu lo test case [GCU] Adding t2 support in gcu lo test case Mar 3, 2025
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

judyjoseph
judyjoseph previously approved these changes Apr 14, 2025
@judyjoseph
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@okaravasi
Copy link
Copy Markdown
Contributor Author

Hello,

This test case fails if it gonna be enabled for multi-asic.

The test case is suppossed to change the Loopback interface under /localhost namespace.
Patch that is applied successfully:
[{"op": "remove", "path": "/LOOPBACK_INTERFACE/Loopback0|10.1.0.1~132"}, {"op": "remove", "path": "/LOOPBACK_INTERFACE/Loopback0|FC00:10::1~1128"}, {"op": "add", "path": "/LOOPBACK_INTERFACE/Loopback0|10.1.0.210~132", "value": {}}, {"op": "add", "path": "/LOOPBACK_INTERFACE/Loopback0|FC00:1::210~1128", "value": {}}]

After that change running database has these values:

$ sonic-cfggen -d -v LOOPBACK_INTERFACE
{'Loopback0': {}, ('Loopback0', '10.1.0.210/32'): {}, ('Loopback0', 'FC00:1::210/128'): {}}
$ sonic-cfggen -n asic0 -d -v LOOPBACK_INTERFACE
{'Loopback0': {}, ('Loopback0', '10.1.0.1/32'): {}, ('Loopback0', 'FC00:10::1/128'): {}, 'Loopback4096': {}, ('Loopback4096', '2603:10e2:400::1/128'): {}, ('Loopback4096', '8.0.0.1/32'): {}}
$ sonic-cfggen -n asic1 -d -v LOOPBACK_INTERFACE
{'Loopback0': {}, ('Loopback0', '10.1.0.1/32'): {}, ('Loopback0', 'FC00:10::1/128'): {}, 'Loopback4096': {}, ('Loopback4096', '2603:10e2:400::2/128'): {}, ('Loopback4096', '8.0.0.2/32'): {}}

As you can see there is an incosistency for Loopback0 between /localhost and asic namespaces.

The test verifies based on "show ip int" command and doesnt' find the updated expected value and fails.

$ show ip int
Interface       Master    IPv4 address/mask    Admin/Oper    BGP Neighbor    Neighbor IP
--------------  --------  -------------------  ------------  --------------  -------------
Loopback0                 10.1.0.1/32          up/up         N/A             N/A

Which means the cli command "show ip int" fetches values based on namespaces cfg?

I am not sure what is the expected here.

We can modify the patch to apply change in localhost as well as in all asic namespaces in case of multiasci duthost and that will pass the case,
but my question is , is the output of "show ip int" expected in above scenario?

Thanks,
Olympia

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Copy Markdown
Contributor

@okaravasi there is a predependency check which is failing can you check

There is a cross-feature dependence. File: tests/generic_config_updater/test_lo_interface.py, import module: tests.bgp.bgp_helpers
There are cross-feature dependencies, which is not allowed in our repo
To resolve this issue, please move the shared function to common place, such as 'tests/common'

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph judyjoseph merged commit fc25fb9 into sonic-net:master Jul 21, 2025
13 checks passed
rolin-arista pushed a commit to rolin-arista/sonic-mgmt-202505-snappi that referenced this pull request Jul 24, 2025
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Aug 7, 2025
ashutosh-agrawal pushed a commit to ashutosh-agrawal/sonic-mgmt that referenced this pull request Aug 14, 2025
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants