[action] [PR:17055] Fix failures of test_dynamic_acl on dualtor#17082
Merged
kperumalbfn merged 1 commit intosonic-net:202411from Feb 21, 2025
Merged
[action] [PR:17055] Fix failures of test_dynamic_acl on dualtor#17082kperumalbfn merged 1 commit intosonic-net:202411from
kperumalbfn merged 1 commit intosonic-net:202411from
Conversation
What is the motivation for this PR?
For dualtor, the content of config_facts['VLAN_INTERFACE'] is like:
grat_arp is not ip address, need to catch the exception and continue to loop the next one until to get ip address
"VLAN_INTERFACE": {
"Vlan1000": {
"grat_arp": "enabled",
"proxy_arp": "enabled",
"192.168.0.1/21": {
},
"fc02:1000::1/64": {
}
}
},
How did you do it?
Add try catch to avoid such kind of exception.
How did you verify/test it?
Run test_dynamic_acl on dualtor
Test evidence on dualtor:
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
-------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
11:56:28 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs
======================================================================================= 12 passed, 123 warnings in 2943.09s (0:49:03) =======================================================================================
DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]>
INFO:root:Can not get Allure report URL. Please check logs
Collaborator
Author
|
/azp run |
11 tasks
Collaborator
Author
|
Original PR: #17055 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
close and reopen to trigger PR test |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kperumalbfn
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
GCU test_dynamic_acl failed on dualtor after #16637
Type of change
Back port request
Approach
What is the motivation for this PR?
For dualtor, the content of config_facts['VLAN_INTERFACE'] is like:
grat_arpis not ip address, need to catch the exception and continue to loop the next one until to get ip addressHow did you do it?
Add try catch to avoid such kind of exception.
How did you verify/test it?
Run test_dynamic_acl on dualtor
Test evidence on dualtor:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation