Fix failures of test_dynamic_acl on dualtor by ZhaohuiS · Pull Request #17055 · sonic-net/sonic-mgmt

ZhaohuiS · 2025-02-20T11:17:01Z

Description of PR

Summary:
Fixes # (issue)
GCU test_dynamic_acl failed on dualtor after #16637

generic_config_updater/test_dynamic_acl.py::test_gcu_acl_arp_rule_creation[IPV4-str2-7050cx3-acs-06-None-default-Vlan1000] 
-------------------------------- live log setup --------------------------------
12:25:59 __init__._fixture_func_decorator         L0073 ERROR  | 
AddrFormatError("failed to detect a valid IP address from 'grat_arp'")
Traceback (most recent call last):
  File "/var/src/sonic-mgmt_vms24-dual-t0-7050-1_646f1405735219c3e54440f4/tests/common/plugins/log_section_start/__init__.py", line 71, in _fixture_func_decorator
    return fixture_func(*args, **kargs)
  File "/var/src/sonic-mgmt_vms24-dual-t0-7050-1_646f1405735219c3e54440f4/tests/generic_config_updater/test_dynamic_acl.py", line 223, in setup
    if netaddr.IPAddress(str(ip_address)).version == 6:
  File "/usr/local/lib/python3.8/dist-packages/netaddr/ip/__init__.py", line 341, in __init__
    raise AddrFormatError('failed to detect a valid IP ' 'address from %r' % addr)
netaddr.core.AddrFormatError: failed to detect a valid IP address from 'grat_arp'

Type of change

Back port request

Approach

What is the motivation for this PR?

For dualtor, the content of config_facts['VLAN_INTERFACE'] is like:
grat_arp is not ip address, need to catch the exception and continue to loop the next one until to get ip address

 "VLAN_INTERFACE": {
      "Vlan1000": {
        "grat_arp": "enabled",
        "proxy_arp": "enabled",
        "192.168.0.1/21": {
          
        },
        "fc02:1000::1/64": {
          
        }
      }
    },

How did you do it?

Add try catch to avoid such kind of exception.

How did you verify/test it?

Run test_dynamic_acl on dualtor
Test evidence on dualtor:

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
-------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
11:56:28 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
======================================================================================= 12 passed, 123 warnings in 2943.09s (0:49:03) =======================================================================================
DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]>
INFO:root:Can not get Allure report URL. Please check logs

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <[email protected]>

mssonicbld · 2025-02-20T11:17:04Z

/azp run

azure-pipelines · 2025-02-20T11:17:17Z

Azure Pipelines successfully started running 1 pipeline(s).

lolyu

LGTM

StormLiangMS

LGTM

What is the motivation for this PR? For dualtor, the content of config_facts['VLAN_INTERFACE'] is like: grat_arp is not ip address, need to catch the exception and continue to loop the next one until to get ip address "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, How did you do it? Add try catch to avoid such kind of exception. How did you verify/test it? Run test_dynamic_acl on dualtor Test evidence on dualtor: -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html -------------------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------------------- 11:56:28 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================================================= 12 passed, 123 warnings in 2943.09s (0:49:03) ======================================================================================= DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]> INFO:root:Can not get Allure report URL. Please check logs

mssonicbld · 2025-02-21T02:24:08Z

Cherry-pick PR to 202405: #17081

What is the motivation for this PR? For dualtor, the content of config_facts['VLAN_INTERFACE'] is like: grat_arp is not ip address, need to catch the exception and continue to loop the next one until to get ip address "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, How did you do it? Add try catch to avoid such kind of exception. How did you verify/test it? Run test_dynamic_acl on dualtor Test evidence on dualtor: -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html -------------------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------------------- 11:56:28 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================================================= 12 passed, 123 warnings in 2943.09s (0:49:03) ======================================================================================= DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]> INFO:root:Can not get Allure report URL. Please check logs

mssonicbld · 2025-02-21T02:24:14Z

Cherry-pick PR to 202411: #17082

What is the motivation for this PR? For dualtor, the content of config_facts['VLAN_INTERFACE'] is like: grat_arp is not ip address, need to catch the exception and continue to loop the next one until to get ip address "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, How did you do it? Add try catch to avoid such kind of exception. How did you verify/test it? Run test_dynamic_acl on dualtor Test evidence on dualtor: -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html -------------------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------------------- 11:56:28 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================================================= 12 passed, 123 warnings in 2943.09s (0:49:03) ======================================================================================= DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]> INFO:root:Can not get Allure report URL. Please check logs

Fix failures of test_dynamic_acl on dualtor

What is the motivation for this PR? For dualtor, the content of config_facts['VLAN_INTERFACE'] is like: grat_arp is not ip address, need to catch the exception and continue to loop the next one until to get ip address "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, How did you do it? Add try catch to avoid such kind of exception. How did you verify/test it? Run test_dynamic_acl on dualtor Test evidence on dualtor: -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html -------------------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------------------- 11:56:28 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ======================================================================================= 12 passed, 123 warnings in 2943.09s (0:49:03) ======================================================================================= DEBUG:tests.conftest:[log_custom_msg] item: <Function test_gcu_acl_nonexistent_table_removal[default-Vlan1000]> INFO:root:Can not get Allure report URL. Please check logs

### Why I did it Fix flakiness of eventd UT - run sub after capture service starts ##### Work item tracking - Microsoft ADO **(number only)**:25650744 #### How I did it Run sub socket after capture socket is initialized #### How to verify it Pipeline

Fix failures of test_dynamic_acl on dualtor

43ea9a3

Signed-off-by: Zhaohui Sun <[email protected]>

ZhaohuiS requested a review from lolyu February 20, 2025 11:17

ZhaohuiS added Request for 202405 branch Request for 202411 branch labels Feb 20, 2025

lolyu approved these changes Feb 21, 2025

View reviewed changes

ZhaohuiS requested a review from StormLiangMS February 21, 2025 01:52

StormLiangMS approved these changes Feb 21, 2025

View reviewed changes

StormLiangMS merged commit ec7f646 into sonic-net:master Feb 21, 2025

StormLiangMS added Approved for 202405 branch Approved for 202411 branch labels Feb 21, 2025

mssonicbld added the Created PR to 202405 branch label Feb 21, 2025

mssonicbld mentioned this pull request Feb 21, 2025

[action] [PR:17055] Fix failures of test_dynamic_acl on dualtor #17081

Merged

11 tasks

mssonicbld added the Created PR to 202411 branch label Feb 21, 2025

mssonicbld mentioned this pull request Feb 21, 2025

[action] [PR:17055] Fix failures of test_dynamic_acl on dualtor #17082

Merged

11 tasks

mssonicbld added Included in 202405 branch and removed Created PR to 202405 branch labels Feb 21, 2025

kperumalbfn pushed a commit that referenced this pull request Feb 21, 2025

Fix failures of test_dynamic_acl on dualtor (#17055) (#17082)

6192d62

Fix failures of test_dynamic_acl on dualtor

mssonicbld added Included in 202411 branch and removed Created PR to 202411 branch labels Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix failures of test_dynamic_acl on dualtor#17055

Fix failures of test_dynamic_acl on dualtor#17055
StormLiangMS merged 1 commit intosonic-net:masterfrom
ZhaohuiS:ZhaohuiS/gcu_acl_dualtor

ZhaohuiS commented Feb 20, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Feb 20, 2025

Uh oh!

azure-pipelines bot commented Feb 20, 2025

Uh oh!

lolyu left a comment

Uh oh!

StormLiangMS left a comment

Uh oh!

mssonicbld commented Feb 21, 2025

Uh oh!

mssonicbld commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ZhaohuiS commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Feb 20, 2025

Uh oh!

azure-pipelines bot commented Feb 20, 2025

Uh oh!

lolyu left a comment

Choose a reason for hiding this comment

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Feb 21, 2025

Uh oh!

mssonicbld commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZhaohuiS commented Feb 20, 2025 •

edited

Loading