Enable new test cases for smartswitch platforms#16935
Merged
bingwang-ms merged 5 commits intosonic-net:masterfrom Mar 3, 2025
Merged
Enable new test cases for smartswitch platforms#16935bingwang-ms merged 5 commits intosonic-net:masterfrom
bingwang-ms merged 5 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/enable_new_ss_tests
branch
from
5ec4198 to
914a9dd
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/enable_new_ss_tests
branch
from
914a9dd to
119f4d1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
reviewed
Feb 19, 2025
bingwang-ms
reviewed
Feb 19, 2025
Collaborator
|
/azp run |
|
Pull request contains merge conflicts. |
Contributor
Author
|
@kevinskwang @XuChen-MSFT please review the Cisco specific updates to test_bfd_basic and test_bfd_scale. Let me know if there any concerns. |
prabhataravind
force-pushed
the
paravind/enable_new_ss_tests
branch
from
f2bea5b to
1f8b9c4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…an tests Signed-off-by: Prabhat Aravind <[email protected]>
Signed-off-by: Prabhat Aravind <[email protected]>
prabhataravind
force-pushed
the
paravind/enable_new_ss_tests
branch
from
1f8b9c4 to
7622c45
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Mar 3, 2025
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Mar 4, 2025
* Add t1-28-lag to the list of topologies supported for certain qos/vxlan tests Signed-off-by: Prabhat Aravind <[email protected]> * Fix skip conditions for test_bfd_basic.py and test_bfd_scale.py Signed-off-by: Prabhat Aravind <[email protected]> --------- Signed-off-by: Prabhat Aravind <[email protected]>
bradh352
added a commit
to bradh352/sonic-mgmt
that referenced
this pull request
Mar 6, 2025
In PR sonic-net#16935 a typo was introduced which introduces this error: ``` 16:33:51 __init__.evaluate_condition L0554 ERROR | Failed to evaluate condition, raw_condition=topo_name not in ['t0', 't0-64', 't0-116', 't0-118', 't0-35', 't0-56', 't0-standalone-32', 't0-standalone-64', 't0-standalone-128', 't0-standalone-256', 'dualtor-56', 'dualtor-120', 'dualtor', 't0-80', 't0-backend', 't1-lag', 't1-28-lag', t1-64-lag', 't1-56-lag', 't1-backend', 't2', 't2_2lc_36p-masic', 't2_2lc_min_ports-masic'] and asic_type not in ['mellanox'], condition_str=topo_name not in ['t0', 't0-64', 't0-116', 't0-118', 't0-35', 't0-56', 't0-standalone-32', 't0-standalone-64', 't0-standalone-128', 't0-standalone-256', 'dualtor-56', 'dualtor-120', 'dualtor', 't0-80', 't0-backend', 't1-lag', 't1-28-lag', t1-64-lag', 't1-56-lag', 't1-backend', 't2', 't2_2lc_36p-masic', 't2_2lc_min_ports-masic'] and asic_type not in ['mellanox'] Traceback (most recent call last): File "/data/sonic-mgmt/tests/common/plugins/conditional_mark/__init__.py", line 549, in evaluate_condition condition_result = bool(eval(condition_str, basic_facts)) File "<string>", line 1 topo_name not in ['t0', 't0-64', 't0-116', 't0-118', 't0-35', 't0-56', 't0-standalone-32', 't0-standalone-64', 't0-standalone-128', 't0-standalone-256', 'dualtor-56', 'dualtor-120', 'dualtor', 't0-80', 't0-backend', 't1-lag', 't1-28-lag', t1-64-lag', 't1-56-lag', 't1-backend', 't2', 't2_2lc_36p-masic', 't2_2lc_min_ports-masic'] and asic_type not in ['mellanox'] ^ SyntaxError: invalid syntax ``` This fixes that typo. Signed-off-by: Brad House (@bradh352)
11 tasks
Collaborator
|
@prabhataravind PR conflicts with 202411 branch |
11 tasks
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
* Add t1-28-lag to the list of topologies supported for certain qos/vxlan tests Signed-off-by: Prabhat Aravind <[email protected]> * Fix skip conditions for test_bfd_basic.py and test_bfd_scale.py Signed-off-by: Prabhat Aravind <[email protected]> --------- Signed-off-by: Prabhat Aravind <[email protected]>
OriTrabelsi
pushed a commit
to OriTrabelsi/sonic-mgmt
that referenced
this pull request
Apr 1, 2025
* Add t1-28-lag to the list of topologies supported for certain qos/vxlan tests Signed-off-by: Prabhat Aravind <[email protected]> * Fix skip conditions for test_bfd_basic.py and test_bfd_scale.py Signed-off-by: Prabhat Aravind <[email protected]> --------- Signed-off-by: Prabhat Aravind <[email protected]>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Enable new test cases for smartswitch which were previously getting skipped
Summary:
Fixes # (31188716)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation