[Snappi] increase tolerance for rounding in m2o tests#16832
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 7, 2025
Merged
Conversation
Signed-off-by: Austin Pham <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
changed the title
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 7, 2025
Description of PR Summary: Increase some tolerance for m2o cases since the normal round() requires exactly .5 above to be rounded up. Fixes # (issue) 3192364 Approach What is the motivation for this PR? Increase some tolerance for our test case How did you do it? How did you verify/test it? validated on T2 testbed 8800 Signed-off-by: Austin Pham <[email protected]>
Collaborator
|
Cherry-pick PR to 202411: #16846 |
This was referenced Feb 7, 2025
Merged
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#67 |
mssonicbld
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: Increase some tolerance for m2o cases since the normal round() requires exactly .5 above to be rounded up. Fixes # (issue) 3192364 Approach What is the motivation for this PR? Increase some tolerance for our test case How did you do it? How did you verify/test it? validated on T2 testbed 8800 Signed-off-by: Austin Pham <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Increase some tolerance for m2o cases since the normal
round()requires exactly .5 above to be rounded up.Fixes # (issue) 3192364
Type of change
Back port request
Approach
What is the motivation for this PR?
Increase some tolerance for our test case
How did you do it?
How did you verify/test it?
validated on T2 testbed 8800
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation