Fix everflow test after py3 upgrade#16806
Closed
veronica-arista wants to merge 1 commit intosonic-net:masterfrom
Closed
Fix everflow test after py3 upgrade#16806veronica-arista wants to merge 1 commit intosonic-net:masterfrom
veronica-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
Fix the python3 issue with the everflow (sonic-net#16087) Increase timeout when polling for the packets to work more reliably with pikez DUTs.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Hi @veronica-arista , sorry I didn't find this PR when I'm working on the same issue. I filed another PR for the same issue #17036 |
Contributor
Author
|
Hi @bingwang-ms , no worries, your PR looks good to me. |
Collaborator
|
hi @bingwang-ms @wsycqyz could you help to take a look this PR? |
Contributor
|
Seems it's also covered in #17036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #16745
Issue #16087 also looks to be a duplicate of this.
Address the
E TypeError: string argument without an encodingerror after the py3 upgrade.Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation