Fix double reboot bug introduced in #16348#16581
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Jan 19, 2025
Merged
Conversation
* Remove one of two reboots performed Signed-off-by: Javier Tan [email protected]
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
Collaborator
|
@sdszhang for viz, is it the RCA of our ixia test failure? The time matches |
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Feb 21, 2025
Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348 + sonic-net#16581) Description of PR Summary: Fixes sonic-net#16289 + merges sonic-net#16581 to remove double reboot bug Approach What is the motivation for this PR? REBOOT_TYPE_POWEROFF reboot causes test failures on T2 as NTP slew doesn't recover for a while How did you do it? Skip dut uptime check on reboot for REBOOT_TYPE_POWEROFF reboot on T2 How did you verify/test it? Was previously casing test_power_off_reboot.py to fail, no longer causing it to fail co-authorized by: [email protected]
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Mar 15, 2025
Description of PR Summary: Revert double root bug introduced in sonic-net#16348 Approach What is the motivation for this PR? Revert bug introduced in sonic-net#16348 that performs 2 reboots instead of one (also performed in line 284/283) How did you do it? Remove one instance of reboot Signed-off-by: Javier Tan [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Revert double root bug introduced in #16348
Type of change
Back port request
Approach
What is the motivation for this PR?
Revert bug introduced in #16348 that performs 2 reboots instead of one (also performed in line 284/283)
How did you do it?
Remove one instance of reboot
How did you verify/test it?
N/A
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A